Skip to content

Conversation

@cedricziel
Copy link
Contributor

Q A
Branch? any
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

@cedricziel cedricziel requested a review from CoderMaggie as a code owner April 8, 2018 16:12
@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Apr 8, 2018
@CoderMaggie CoderMaggie mentioned this pull request Apr 9, 2018
@CoderMaggie CoderMaggie changed the base branch from 1.1 to 1.0 April 9, 2018 09:50
@cedricziel
Copy link
Contributor Author

Rebased to target 1.0

the `AverageRatingUpdater <https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/ReviewBundle/Updater/AverageRatingUpdater.php>`_ service.

It has inside the `AverageRatingCalculator <https://github.com/Sylius/Sylius/blob/master/src/Sylius/Component/Review/Calculator/AverageRatingCalculator.php>`_,
It wrapps the `AverageRatingCalculator <https://github.com/Sylius/Sylius/blob/master/src/Sylius/Component/Review/Calculator/AverageRatingCalculator.php>`_,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doubled "p"?

@cedricziel
Copy link
Contributor Author

Amended. Thx for the review.

@pamil pamil merged commit 7725a36 into Sylius:1.0 Apr 10, 2018
@pamil
Copy link
Contributor

pamil commented Apr 10, 2018

Thanks! :)

@cedricziel cedricziel deleted the patch-2 branch April 10, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Documentation related issues and PRs - requests, fixes, proposals.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants