Fix invalid YAML tag syntax #9328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
approved these changes
Apr 13, 2018
pamil
approved these changes
Apr 13, 2018
Contributor
|
Do we need to quote this parameter (like in #9334)? |
Contributor
Author
|
No, there's no reason to quote it. It's a YAML tag. There's something not quite right with #9334 (I'll look into it further.) |
Contributor
Author
|
@pamil Anything else you want me to change here? Should it go into a different branch? |
Contributor
|
It just got out of view, thanks Teoh! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.1 because it requires Symfony 3.4
Symfony introduced invalid YAML syntax but they've since fixed it. This removes a deprecation message. See symfony/symfony#22913