Skip to content

[Documentation] Change parameters to env variables#9739

Merged
pamil merged 1 commit into
Sylius:1.3from
Zales0123:docs/change-parameters-to-env-variables
Oct 2, 2018
Merged

[Documentation] Change parameters to env variables#9739
pamil merged 1 commit into
Sylius:1.3from
Zales0123:docs/change-parameters-to-env-variables

Conversation

@Zales0123

Copy link
Copy Markdown
Contributor
Q A
Branch? 1.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

There are also some references to parameters in other parts of the cookbook, but AFAIK @CoderMaggie is working on improving cookbook as well, moreover, I honestly don't know how some of them should look like (for example redis configuration).

@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Sep 28, 2018
Comment thread docs/cookbook/emails/mailer.rst Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAILER_URL ->

``MAILER_URL``

@Zales0123 Zales0123 force-pushed the docs/change-parameters-to-env-variables branch from 6596f66 to dc2a360 Compare October 1, 2018 08:03
@pamil pamil force-pushed the docs/change-parameters-to-env-variables branch 2 times, most recently from eddc45d to d529c0d Compare October 2, 2018 10:25
@pamil

pamil commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

Rebased the PR for you :)

@Zales0123 Zales0123 force-pushed the docs/change-parameters-to-env-variables branch from d529c0d to 695288e Compare October 2, 2018 10:31
@Zales0123 Zales0123 force-pushed the docs/change-parameters-to-env-variables branch from 695288e to 27c56ea Compare October 2, 2018 10:32
@pamil pamil merged commit a0cfdf1 into Sylius:1.3 Oct 2, 2018
@pamil

pamil commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

Thanks, Matt! 🎉

@Zales0123 Zales0123 deleted the docs/change-parameters-to-env-variables branch October 2, 2018 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Documentation related issues and PRs - requests, fixes, proposals.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants