Skip to content

[Maintenance] Configure builds on postgressql & mariadb#12880

Merged
GSadee merged 8 commits into
Sylius:masterfrom
Arminek:maintenance/postgress-builds
Sep 21, 2021
Merged

[Maintenance] Configure builds on postgressql & mariadb#12880
GSadee merged 8 commits into
Sylius:masterfrom
Arminek:maintenance/postgress-builds

Conversation

@Arminek

@Arminek Arminek commented Aug 11, 2021

Copy link
Copy Markdown
Contributor
Q A
Branch? master
Bugfix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

🖖 Hello, Sylius community,
We want to be better at supporting DB like Postgresql & MariaDB. So our first step in this direction is running our test suite on these DBs. To see what is not working correctly. Next steps -> fix these errors one by one. Stay tuned! 🖖

@Arminek Arminek requested a review from a team as a code owner August 11, 2021 12:06
@probot-autolabeler probot-autolabeler Bot added the Maintenance CI configurations, READMEs, releases, etc. label Aug 11, 2021
@Arminek Arminek force-pushed the maintenance/postgress-builds branch 3 times, most recently from cd00353 to 83a7f0f Compare August 12, 2021 11:36
@Arminek Arminek changed the title [Maintenance] Configure builds on postgressql [Maintenance] Configure builds on postgressql & mariadb Aug 16, 2021
Comment thread .github/workflows/application.yml Outdated
@Arminek Arminek force-pushed the maintenance/postgress-builds branch 2 times, most recently from e638466 to b0137a8 Compare August 26, 2021 12:07
@lchrusciel lchrusciel closed this Sep 20, 2021
@lchrusciel lchrusciel reopened this Sep 20, 2021
@lchrusciel

Copy link
Copy Markdown
Contributor

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "maintenance/postgress-builds" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel lchrusciel changed the base branch from master to 1.10 September 20, 2021 16:41
@lchrusciel lchrusciel force-pushed the maintenance/postgress-builds branch from b0137a8 to 2548ff7 Compare September 20, 2021 16:41
@lchrusciel lchrusciel changed the base branch from 1.10 to master September 20, 2021 16:41
@lchrusciel lchrusciel force-pushed the maintenance/postgress-builds branch from 2548ff7 to 87d4ea6 Compare September 20, 2021 16:41
@lchrusciel

Copy link
Copy Markdown
Contributor

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "maintenance/postgress-builds" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@Zales0123 Zales0123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be worth extracting these configurations to the separate workflow file? Just to keep things cleaner :)

test-application-without-frontend-postgres:
runs-on: ubuntu-18.04

name: "Test non-JS application (PHP ${{ matrix.php }}, Symfony ${{ matrix.symfony }}, PostgresSQL ${{ matrix.postgres }})"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: "Test non-JS application (PHP ${{ matrix.php }}, Symfony ${{ matrix.symfony }}, PostgresSQL ${{ matrix.postgres }})"
name: "Test non-JS application (PHP ${{ matrix.php }}, Symfony ${{ matrix.symfony }}, PostgreSQL ${{ matrix.postgres }})"

@GSadee GSadee merged commit c0bdc8d into Sylius:master Sep 21, 2021
@GSadee

GSadee commented Sep 21, 2021

Copy link
Copy Markdown
Member

Thank you, Arkadiusz! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants