Update BuildTestAppAction to v3.0.1 #18459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be8cefb to
87bad16
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ Preview Environment deleted from BunnyshellAvailable commands:
|
87bad16 to
621df47
Compare
GSadee
approved these changes
Oct 22, 2025
GSadee
added a commit
that referenced
this pull request
Oct 23, 2025
| Q | A |-----------------|----- | Branch? | 1.14 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | #18459 (it introduced step-based chrome run) | License | MIT ## Description This PR resolves the "user data directory is already in use" error that causes all Panther tests to fail on Symfony 5.4 matrix jobs after upgrading to BuildTestAppAction v3.0.1. The issue occurs because BuildTestAppAction v3.0.1 starts a background Chrome process (for Chromedriver on port 9222) without specifying a user-data-dir, which conflicts with Panther's Chrome instance attempting to use the same default directory. ## Root Cause The Sylius behat.yml.dist configuration was incorrectly placing Chrome arguments under `options.browser_arguments`, which is **completely ignored** by the behat-panther-extension. The correct configuration path is `manager_options.capabilities.goog:chromeOptions.args`. This configuration error was introduced in commit 04a222b and went unnoticed because it only manifested when BuildTestAppAction v3.0.1 removed the default Chrome installation (which was already running with a user-data-dir). ## Changes - **behat.yml.dist**: Fixed Chrome arguments configuration to use the correct path: - Moved arguments from `sessions.panther.panther.options.browser_arguments` (ignored) - To `sessions.panther.panther.manager_options.capabilities.goog:chromeOptions.args` (correct) - Added `--user-data-dir=/tmp/panther-chrome-data` to prevent conflicts with Chromedriver's Chrome instance This ensures Panther's Chrome process uses a unique user data directory, allowing it to run alongside BuildTestAppAction's Chrome instance without conflicts. ## Technical Details - BuildTestAppAction's Chrome uses default user-data-dir (or will use `/tmp/chrome-chromedriver-behat` in future versions) - Panther's Chrome now explicitly uses `/tmp/panther-chrome-data` - The fix resolves the issue on both Symfony 5.4 (Panther v2.1.1) and Symfony 6.4 (Panther v2.2.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SyliusLabs/BuildTestAppAction from v2.3 to v3.0 across all E2E and frontend CI workflows