Skip to content

Fixes two segfaults in CAF processing of SBND v10_06_00_09, develop PR #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kjplows merged 4 commits into from
Dec 17, 2025
Merged

Fixes two segfaults in CAF processing of SBND v10_06_00_09, develop PR #610

kjplows merged 4 commits into from
Dec 17, 2025

Conversation

@kjplows
Copy link
Contributor

@kjplows kjplows commented Nov 28, 2025

Geant4WeightCalc::GetWeight gets a guard against trajectory points outside the world volume sbn::GetWallCross gets a guard against lines that don't intersect the detector

Description

Adds guards discovered to be needed upon reprocessing of the SBND Spring BNB+cosmics MC. For details, see #609.

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@kjplows
Adds guards to Geant4WeightCalc::GetWeight and sbn::GetWallCross
e5bf134 
Geant4WeightCalc::GetWeight gets a guard against trajectory points outside the world volume
sbn::GetWallCross gets a guard against lines that don't intersect the detector
@kjplows kjplows self-assigned this Nov 28, 2025
@kjplows kjplows added the bugfix Addresses one or more bugs label Nov 28, 2025
@kjplows kjplows changed the title Adds guards to Geant4WeightCalc::GetWeight and sbn::GetWallCross Fixes two segfaults in CAF processing of SBND v10_06_00_09, develop PR Nov 28, 2025
@kjplows kjplows mentioned this pull request Nov 28, 2025
Merged
6 tasks
@kjplows kjplows moved this to Open pull requests in SBN software development Nov 28, 2025
sungbinoh
sungbinoh approved these changes Nov 28, 2025
View reviewed changes
Copy link
Contributor

@sungbinoh sungbinoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kjplows !
The updates look good to me.
I cannot see any issue with updates inGetWallCross to FillTrue.cxx's FillTrueG4Particle.

PetrilloAtWork
PetrilloAtWork approved these changes Dec 3, 2025
View reviewed changes
Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved like #609.

@kjplows
Copy link
Contributor Author

kjplows commented Dec 3, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_00

@FNALbuild
Copy link

FNALbuild commented Dec 3, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

FNALbuild commented Dec 3, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

FNALbuild commented Dec 3, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

FNALbuild commented Dec 3, 2025

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

FNALbuild commented Dec 3, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

FNALbuild commented Dec 3, 2025

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Open pull requests to To merge in SBN software development Dec 3, 2025
@kjplows kjplows merged commit 266a891 into develop Dec 17, 2025
3 of 6 checks passed
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Dec 17, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sungbinoh sungbinoh sungbinoh approved these changes

@jzennamo jzennamo jzennamo approved these changes

@PetrilloAtWork PetrilloAtWork PetrilloAtWork approved these changes

Assignees

@kjplows kjplows

Labels

bugfix Addresses one or more bugs

Projects

SBN software development
Status: Recently done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kjplows @FNALbuild @sungbinoh @jzennamo @PetrilloAtWork