Fix/cohort extractor output paths #1506
Merged
+30
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1506 +/- ##
=======================================
Coverage 67.87% 67.88%
=======================================
Files 185 185
Lines 6544 6546 +2
=======================================
+ Hits 4442 4444 +2
Misses 2102 2102
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
rkm
requested changes
Mar 31, 2023
Member
rkm
left a comment
There was a problem hiding this comment.
Looks great - just need to change the name of the news file to match the PR (not the issue number)
rkm
approved these changes
Mar 31, 2023
rkm
approved these changes
Mar 31, 2023
Member
|
@darshad-github feel free to hit the big green "merge" button! 😄 |
rkm
added a commit
that referenced
this pull request
Oct 4, 2024
11 tasks
rkm
added a commit
that referenced
this pull request
Oct 10, 2024
rkm
added a commit
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request fixes an issue spotted when running a test extraction. The problem occurs when UIDs present in the PACS data that are used to generate the extraction output paths
<StudyInstanceUID>/<SeriesInstanceUID>/...start with a dot. This indicates a hidden directory in Linux causing some directories to appear "missing" from the extraction output unless hidden files are shown.To fix this issue, the leading periods are now removed when generating the output path in the DefaultProjectPathResolver class. Additionally, a new test case has been added to the DefaultProjectPathResolverTest class to ensure that hidden directories are handled correctly.
Types of changes
What types of changes does your code introduce? Tick all that apply.
[skip ci]Checklist
By opening this PR, I confirm that I have:
Issues
If relevant, tag any issues that are expected to be resolved with this PR. E.g.: