Skip to content

allow specifying path to DynamicRules file #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rkm merged 3 commits into from
Sep 17, 2024
Merged

allow specifying path to DynamicRules file #1938

rkm merged 3 commits into from
Sep 17, 2024

Conversation

@rkm
Copy link
Member

@rkm rkm commented Sep 17, 2024 •
edited
Loading

Proposed Changes

This can now be set in the GlobalOptions for CohortExtractor.

Note that a slight hack was needed, as the rejectors are constructed through reflection via ObjectConstructor. We should probably remove this and replace it with a static factory class or similar, as the reflection calls make dealing with constructor parameters quite opaque. I'm not even certain that the existing code functions for the other ejector types.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

@rkm rkm marked this pull request as ready for review September 17, 2024 08:51
@rkm rkm enabled auto-merge September 17, 2024 08:51
@codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.09%. Comparing base (52677a5) to head (7f9f8cd).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1938      +/-   ##
==========================================
+ Coverage   64.07%   64.09%   +0.02%     
==========================================
  Files         177      177              
  Lines        6525     6529       +4     
  Branches      968      969       +1     
==========================================
+ Hits         4181     4185       +4     
  Misses       2057     2057              
  Partials      287      287

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm requested a review from a team September 17, 2024 09:08
@rkm rkm merged commit 86a4ae1 into main Sep 17, 2024
@rkm rkm deleted the dynamic-rules-path branch September 17, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howff howff howff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rkm @howff