Skip to content

Fix program names in MessageHeader and logging setup #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rkm merged 7 commits into from
Oct 3, 2024
Merged

Fix program names in MessageHeader and logging setup #1954

rkm merged 7 commits into from
Oct 3, 2024

Conversation

@rkm
Copy link
Member

@rkm rkm commented Oct 2, 2024 •
edited
Loading

Proposed Changes

Avoid guessing the program name by parsing the Type namespace, and pass in directly instead.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

@codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.89%. Comparing base (f914ff5) to head (f2a8198).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/SmiServices/Common/Options/SmiCliInit.cs 75.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1954      +/-   ##
==========================================
+ Coverage   64.30%   64.89%   +0.58%     
==========================================
  Files         180      181       +1     
  Lines        6564     6574      +10     
  Branches      977      973       -4     
==========================================
+ Hits         4221     4266      +45     
+ Misses       2056     2023      -33     
+ Partials      287      285       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm marked this pull request as ready for review October 3, 2024 20:58
@rkm rkm requested a review from a team October 3, 2024 20:58
@rkm rkm merged commit 19d40a9 into main Oct 3, 2024
@rkm rkm deleted the fix/program-header-log-names branch October 3, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howff howff howff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

log file path is wrong after condensing csprojs to single project MessageHeader ProducerExecutableName is "smi" for all messages

3 participants

@rkm @howff