Skip to content

add SelfContained property #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rkm merged 2 commits into from
Nov 15, 2024
Merged

add SelfContained property #1993

rkm merged 2 commits into from
Nov 15, 2024

Conversation

@rkm
Copy link
Member

@rkm rkm commented Nov 15, 2024 •
edited
Loading

Proposed Changes

This is apparently now required (in addition to, or ignoring the --self-contained CLI option) in order to create a deployable archive.

See https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/runtimespecific-app-default

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

rkm added 2 commits November 15, 2024 15:00
@rkm
add SelfContained property
357ef30 
This is apparently now required (in addition to, or ignoring the
--self-contained CLI option) in order to create a deployable archive.

See
https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/runtimespecific-app-default
@rkm
add news file
7594395
@rkm rkm enabled auto-merge (rebase) November 15, 2024 15:03
@codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.77%. Comparing base (72b63be) to head (7594395).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1993   +/-   ##
=======================================
  Coverage   64.77%   64.77%           
=======================================
  Files         183      183           
  Lines        6558     6558           
  Branches      965      965           
=======================================
  Hits         4248     4248           
  Misses       2023     2023           
  Partials      287      287

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm merged commit afc108b into main Nov 15, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rkm