Skip to content

Make installation script respect $XDG_DATA_HOME #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Schniz merged 8 commits into from
Nov 17, 2022
Merged

Make installation script respect $XDG_DATA_HOME #614

Schniz merged 8 commits into from
Nov 17, 2022

Conversation

@jonz94
Copy link
Contributor

@jonz94 jonz94 commented Dec 28, 2021

Related to #357 and #613

@vercel
Copy link

vercel bot commented Dec 28, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/schniz/fnm/33bgG92ig23UrGrNwh6ctf2yHZHB
✅ Preview: https://fnm-git-fork-jonz94-main-schniz.vercel.app

Schniz
Schniz reviewed Dec 29, 2021
View reviewed changes
@page-down page-down mentioned this pull request Jan 4, 2022
Open
page-down
page-down reviewed Jan 4, 2022
View reviewed changes
Copy link

@page-down page-down left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path under macOS is wrong and needs to be fixed.

@sarmong
Copy link

sarmong commented Nov 2, 2022

Will this be ever merged?

@Schniz
Copy link
Owner

Schniz commented Nov 3, 2022

I'm gonna update this PR so it'll run CI

@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 8c05fa0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fnm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Schniz Schniz added the PR: Bugfix A bug was fixed label Nov 3, 2022
@Schniz Schniz merged commit 9d0dd1b into Schniz:master Nov 17, 2022
@github-actions github-actions bot mentioned this pull request Nov 17, 2022
Merged
@page-down
Copy link

page-down commented Nov 18, 2022

@Schniz
The PR has been merged, however XDG_DATA_HOME is still not respected under macOS.

https://github.com/Schniz/fnm/issues/622

This results in fnm being installed to ~/.local/share/fnm, however the FNM_DIR given by fnm env is still ~/Library/Application Support/fnm.
Since we already have src/directories.rs, it seems relatively straightforward.
Do you have any other concerns?

nzhl pushed a commit to nzhl/fnm that referenced this pull request Nov 18, 2022
@jonz94 @Schniz @nzhl
Make installation script respect $XDG_DATA_HOME (Schniz#614)
bc2baa3 
* Make installation script respect $XDG_DATA_HOME

* Add os check to determine INSTALL_DIR default location

* Minor refactor

* Use `test -n` with double quotes

* Fix space in directory name issue

* Create yellow-otters-develop.md

Co-authored-by: Gal Schlezinger <gal@spitfire.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Schniz Schniz Schniz left review comments

+2 more reviewers

@ljharb ljharb ljharb left review comments

@page-down page-down page-down left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Bugfix A bug was fixed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jonz94 @sarmong @Schniz @page-down @ljharb