Skip to content

Successfully build on Windows #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Schniz merged 17 commits into from
May 28, 2019
Merged

Successfully build on Windows #88

Schniz merged 17 commits into from
May 28, 2019

Conversation

@ulrikstrid
Copy link
Contributor

@ulrikstrid ulrikstrid commented Mar 26, 2019 •
edited
Loading

This PR makes fnm build on Windows. It shouldn't change any behavior at this point and will not run on Windows at this point.

@Schniz
Copy link
Owner

Schniz commented Mar 26, 2019

oh my god

👏 ❤️

@Schniz Schniz added the PR: New Feature A new feature was added label Mar 30, 2019
@Schniz Schniz mentioned this pull request May 21, 2019
Merged
@ulrikstrid ulrikstrid changed the title [WIP] Windows support Windows support May 23, 2019
@ulrikstrid
Copy link
Contributor Author

ulrikstrid commented May 23, 2019

I think this PR should be ready for review/merge. I can rebase it to 1 commit if that is preferable.

As we talked about I added a windows.json that extends the package.json and then we can use windows with esy --project windows .... The current version of pesy that is used can't run on Windows so I opted to run dune directly instead.

@ulrikstrid ulrikstrid mentioned this pull request May 23, 2019
Closed
@Schniz Schniz merged commit c94ebc2 into Schniz:master May 28, 2019
@Schniz Schniz changed the title Windows support Successfully build on Windows May 28, 2019
@ulrikstrid ulrikstrid deleted the windows-support branch May 28, 2019 09:21
@Schniz Schniz added PR: Internal An internal work has been made and removed PR: New Feature A new feature was added labels Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Internal An internal work has been made

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ulrikstrid @Schniz