Skip to content

Use var_os instead of `var #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Schniz merged 3 commits into from
Aug 13, 2024
Merged

Use var_os instead of `var #1223

Schniz merged 3 commits into from
Aug 13, 2024

Conversation

@mo8it
Copy link
Contributor

@mo8it mo8it commented Aug 11, 2024

var_os doesn't need to check if the value of the variable is in UTF8. split_paths and PathBuf can deal with OsString

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 273148f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fnm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 9:06am

@Schniz
Copy link
Owner

Schniz commented Aug 12, 2024

nice! can you please add a changeset? 🙏

@mo8it
Copy link
Contributor Author

mo8it commented Aug 12, 2024

Done.

Just a small feedback: It is much easier for maintainers to take care of the changelog. It makes the life of contributors easier and allows you to use your own words to describe what changes are relevant to users.

@Schniz
Copy link
Owner

Schniz commented Aug 13, 2024

Done.

Just a small feedback: It is much easier for maintainers to take care of the changelog. It makes the life of contributors easier and allows you to use your own words to describe what changes are relevant to users.

agree
will do it from now on 🙏

@Schniz Schniz merged commit 2b211ef into Schniz:master Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 13, 2024
Merged
@mo8it mo8it deleted the var-os branch August 13, 2024 07:41
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Open
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Open
@BrewTestBot BrewTestBot mentioned this pull request Oct 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mo8it @Schniz