Skip to content

Conversation

@tatchi
Copy link
Contributor

@tatchi tatchi commented Feb 19, 2020

Trying to fix #121. I still need to write the tests but so you can already have a look and give your comments.

The logic goes like this:

  • If no version is matching => we print out a message (like we used to)
  • If only one version is matching (because the user provided a specific version 6.17.1 or because the prefix match only one installed version) => the version get uninstalled
  • If multiple installed versions are matched: we print out the matching installed versions and ask the user to re-run the command with the correct version to uninstall.

Note: it's not possible to uninstall using latest or latest-v9.x, ... But that's already the case so nothing has changed here.

Copy link
Owner

@Schniz Schniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! looks very good 👏
can you please add tests?

@Schniz Schniz added the PR: New Feature A new feature was added label Feb 20, 2020
@tatchi tatchi requested a review from Schniz February 21, 2020 17:37
@Schniz Schniz merged commit 2799222 into Schniz:master Feb 25, 2020
@Schniz
Copy link
Owner

Schniz commented Feb 25, 2020

Thanks @tatchi! 💰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: New Feature A new feature was added

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uninstall usability

2 participants