-
Notifications
You must be signed in to change notification settings - Fork 595
Refer to homebrew/core formula instead of custom tap #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refer to homebrew/core formula instead of custom tap #307
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/schniz/fnm/3n8sl5se6 |
|
Not sure why the test failed to find the Perhaps a re-run could validate that it indeed exists in |
|
@Schniz, this time, it worked for |
|
I wonder if we should add a step (only for MacOS) that does |
That sounds like a potential solution. I like it 🙂 I'll make the following change: diff --git a/.github/workflows/installation_script.yml b/.github/workflows/installation_script.yml
index 1945731..a079e25 100644
--- a/.github/workflows/installation_script.yml
+++ b/.github/workflows/installation_script.yml
@@ -66,8 +66,8 @@ jobs:
- run: "sudo apt-get install -y ${{ matrix.shell }}"
name: Install ${{matrix.shell}} using apt-get
if: matrix.setup.os == 'ubuntu'
- - run: "brew install ${{ matrix.shell }}"
- name: Install ${{matrix.shell}} using Homebrew
+ - run: "brew update && brew install ${{ matrix.shell }}"
+ name: Update formulae and install ${{matrix.shell}} using Homebrew
if: matrix.setup.os == 'macos'
- run: |
if [ -f ~/.bashrc ]; then |
|
@Schniz, it worked 😋 👍 Thanks for the recommendation! |
Schniz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
Updated locations which reference the deprecated tap. Homebrew instructions will now relate to the
homebrew/coreformula.I would have liked to add an automated Homebrew release strategy in this PR as well, but it seems that the current release strategy is done manually (i.e. outside of GitHub Actions (GHA) at least; please correct me if I'm wrong). A new issue outlining an automated strategy for pushes to the main branch done via GHA would definitely help get the ball rolling with this 😉
Relates to Schniz/homebrew-tap#12.