Skip to content

Conversation

@jameschensmith
Copy link
Contributor

Updated locations which reference the deprecated tap. Homebrew instructions will now relate to the homebrew/core formula.

I would have liked to add an automated Homebrew release strategy in this PR as well, but it seems that the current release strategy is done manually (i.e. outside of GitHub Actions (GHA) at least; please correct me if I'm wrong). A new issue outlining an automated strategy for pushes to the main branch done via GHA would definitely help get the ball rolling with this 😉

Relates to Schniz/homebrew-tap#12.

@vercel
Copy link

vercel bot commented Oct 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/schniz/fnm/3n8sl5se6
✅ Preview: https://fnm-git-chore-refer-to-homebrew-core-formula.schniz.vercel.app

@jameschensmith
Copy link
Contributor Author

jameschensmith commented Oct 28, 2020

Not sure why the test failed to find the homebrew/core formula 🤔 I can validate it's there:

$ brew info fnm
fnm: stable 1.22.2 (bottled), HEAD
Fast and simple Node.js version manager
https://fnm.vercel.app
Not installed
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/fnm.rb
License: GPL-3.0-only
==> Dependencies
Build: rust ✘
==> Options
--HEAD
	Install HEAD version
==> Analytics
install: 13 (30 days), 13 (90 days), 37 (365 days)
install-on-request: 13 (30 days), 13 (90 days), 37 (365 days)
build-error: 0 (30 days)

Perhaps a re-run could validate that it indeed exists in homebrew/core?

@jameschensmith
Copy link
Contributor Author

jameschensmith commented Oct 28, 2020

@Schniz, this time, it worked for fish, macos but not bash, macos. Only fish, macos was run the first time, because when it failed the other ones were skipped. There's got to be some caching happening in the background, which is making Homebrew not find the formula and fail the first time 🤔

@Schniz
Copy link
Owner

Schniz commented Oct 28, 2020

I wonder if we should add a step (only for MacOS) that does brew update before installing. We already do brew install SHELL, we can turn it into a multiline expression and stick a brew update before that

@jameschensmith
Copy link
Contributor Author

jameschensmith commented Oct 28, 2020

I wonder if we should add a step (only for MacOS) that does brew update before installing. We already do brew install SHELL, we can turn it into a multiline expression and stick a brew update before that

That sounds like a potential solution. I like it 🙂 I'll make the following change:

diff --git a/.github/workflows/installation_script.yml b/.github/workflows/installation_script.yml
index 1945731..a079e25 100644
--- a/.github/workflows/installation_script.yml
+++ b/.github/workflows/installation_script.yml
@@ -66,8 +66,8 @@ jobs:
       - run: "sudo apt-get install -y ${{ matrix.shell }}"
         name: Install ${{matrix.shell}} using apt-get
         if: matrix.setup.os == 'ubuntu'
-      - run: "brew install ${{ matrix.shell }}"
-        name: Install ${{matrix.shell}} using Homebrew
+      - run: "brew update && brew install ${{ matrix.shell }}"
+        name: Update formulae and install ${{matrix.shell}} using Homebrew
         if: matrix.setup.os == 'macos'
       - run: |
           if [ -f ~/.bashrc ]; then

@jameschensmith
Copy link
Contributor Author

jameschensmith commented Oct 28, 2020

@Schniz, it worked 😋 👍 Thanks for the recommendation!

Copy link
Owner

@Schniz Schniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@Schniz Schniz added the PR: Documentation Some docs were added label Oct 29, 2020
@Schniz Schniz changed the title Refer to homebrew/core formula Refer to homebrew/core formula instead of custom tap Oct 29, 2020
@Schniz Schniz merged commit f976df5 into Schniz:master Oct 29, 2020
@jameschensmith jameschensmith deleted the chore/refer-to-homebrew-core-formula branch October 29, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Documentation Some docs were added

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants