Modernise setup scripts #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 31bd497.
Collaborator
Author
|
Proof that the project metadata's new location still delivers something meaningful: |
pelson
reviewed
Sep 26, 2024
pelson
reviewed
Sep 26, 2024
pelson
reviewed
Sep 26, 2024
pelson
previously approved these changes
Sep 26, 2024
Member
pelson
left a comment
There was a problem hiding this comment.
LGTM. A few small suggestions, but they are non-essential (and could e followed up separately).
trexfeathers
commented
Sep 26, 2024
pp-mo
approved these changes
Sep 26, 2024
Member
pp-mo
left a comment
There was a problem hiding this comment.
1 tiny quibble
rest OK afaict, but still worryingly intricate + complex (if less obsolete).
Not your fault, I guess we just need it, for now.
Member
|
Hope I'm not premature here. |
Collaborator
Author
stephenworsley
added a commit
to stephenworsley/cf-units
that referenced
this pull request
Sep 27, 2024
* main: [DOCS] Update docstring for date2num (module function) (SciTools#483) Modernise setup scripts (SciTools#484) Make antlr optional (SciTools#423) Ruff: smaller steps (SciTools#364) Updated docstring for num2date. (SciTools#467) updated conda lock files (SciTools#479) Revert to 00:03 Mondays for lockfile updates. (SciTools#480) New trigger time for GMT. (SciTools#478) Check lockfile updates @ 3pm daily (temporary for testing). (SciTools#477) Fixlocks (SciTools#470) # Conflicts: # pyproject.toml # requirements/cf-units.yml # requirements/locks/py310-lock-linux-64.txt # requirements/locks/py310-lock-osx-64.txt # requirements/locks/py310-lock-win-64.txt # requirements/locks/py311-lock-linux-64.txt # requirements/locks/py311-lock-osx-64.txt # requirements/locks/py311-lock-win-64.txt # requirements/locks/py312-lock-linux-64.txt # requirements/locks/py312-lock-osx-64.txt # requirements/locks/py312-lock-win-64.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Closes #454