locale-remulator: Add version 1.6.0 #16778

soleige · 2025-12-12T07:32:03Z

locale-remulator: Add version 1.6.0

Closes #16726
Supersedes #11473

Added locale-remulator as requested. This is similar with Locale Emulator with x64 support.

Verification:

Verified installation locally.
Verified context menu installation via install-context.ps1 script.
Verified persistence of LRConfig.xml (auto-generates default config if missing).
Verified application launch and functionality.

Manifest Changes:

Added pre_install script to generate a valid LRConfig.xml with default profiles to prevent LREditor crash on first run.
Added post_install script to facilitate context menu registration without requiring UAC during installation.
Added extract_dir to handle the nested directory structure.
Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
I have read the Contributing Guide

Summary by CodeRabbit

New Features
- Adds Scoop package support for Locale Remulator with automatic updates and 64-bit build distribution
- Creates a default persistent configuration if missing and preserves it across updates
- Installs the application binary and shortcut, and generates install/uninstall context scripts
- Enables version checking via GitHub for autoupdate management

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Add new manifest for Locale Remulator.

coderabbitai · 2025-12-12T07:32:17Z

Walkthrough

Adds a new Scoop manifest bucket/locale-remulator.json for Locale Remulator: package metadata, 64-bit download and hash, autoupdate settings, pre-install logic to create a default LRConfig.xml if missing, post-install hooks to generate install/uninstall context scripts, binaries, shortcut, and persistence for LRConfig.xml.

Changes

Cohort / File(s)	Summary
New Locale Remulator Package Manifest `bucket/locale-remulator.json`	Adds a Scoop-style manifest declaring version, description, homepage, license, notes, prerequisites, 64-bit download URL and SHA256, extract directory, `persist` for `LRConfig.xml`, `pre_install` to create a default `LRConfig.xml` if absent, `post_install` to generate `install-context.ps1` and `uninstall-context.ps1` when missing, `bin` and `shortcuts` entries, `checkver` and `autoupdate` templates targeting the GitHub releases pattern.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Verify the 64-bit release URL and SHA256 match the referenced GitHub release asset.
Inspect pre_install PowerShell that creates the default LRConfig.xml for correctness and XML validity.
Review post_install script generation for install-context.ps1 / uninstall-context.ps1 paths and contents.
Confirm bin and shortcuts entries point to the correct installed executable paths.
Validate autoupdate pattern aligns with release asset naming and checkver source.

Poem

🐰 I hopped into the manifest patch,
Created configs, no need to scratch,
Scripts for install, scripts for clean,
Locale Remulator—keen and lean,
Ready to jump across each patch!

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'locale-remulator: Add version 1.6.0' clearly summarizes the main change—adding a new package version to the repository.
Description check	✅ Passed	The description includes issue links, verification checklist, detailed manifest changes, and confirms completion of the contributing guide requirements.
Linked Issues check	✅ Passed	The PR implements all requirements from issue #16726: adds a manifest for Locale Remulator with 64-bit support, meets popularity criteria, includes English documentation, and provides version-specific downloads.
Out of Scope Changes check	✅ Passed	The changes are limited to adding a single manifest file (bucket/locale-remulator.json) directly aligned with the issue objectives and do not include unrelated modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8b940b and 09f7eb0.

📒 Files selected for processing (1)

bucket/locale-remulator.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

bucket/locale-remulator.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: WindowsPowerShell

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-12T07:33:09Z

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

locale-remulator

Check the full log for details.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

bucket/locale-remulator.json (1)

20-33: Write LRConfig.xml to $persist_dir (and create the directory) to match the guard + persist behavior.
Right now you check $persist_dir\LRConfig.xml but write to $dir\LRConfig.xml, which can become order-dependent across installs/upgrades.

 "pre_install": [
     "if (!(Test-Path \"$persist_dir\\LRConfig.xml\")) {",
+    "    if (!(Test-Path \"$persist_dir\")) { New-Item -Path \"$persist_dir\" -ItemType Directory -Force | Out-Null }",
     "    $content = @(",
     "        '<LRConfig><Profiles Type=\"exe\">'",
     "        '<Profile Name=\"Run in Japanese\" Guid=\"11111111-1111-1111-1111-111111111111\"><Location>ja-JP</Location><CodePage>932</CodePage><LCID>1041</LCID><TimeZone>Tokyo Standard Time</TimeZone><Bias>540</Bias><RunAsAdmin>false</RunAsAdmin><HookIME>false</HookIME><HookLCID>true</HookLCID></Profile>'",
     "        '<Profile Name=\"Run in Japanese (Admin)\" Guid=\"22222222-2222-2222-2222-222222222222\"><Location>ja-JP</Location><CodePage>932</CodePage><LCID>1041</LCID><TimeZone>Tokyo Standard Time</TimeZone><Bias>540</Bias><RunAsAdmin>true</RunAsAdmin><HookIME>true</HookIME><HookLCID>true</HookLCID></Profile>'",
     "        '<Profile Name=\"Run in Taiwan (Admin)\" Guid=\"33333333-3333-3333-3333-333333333333\"><Location>zh-TW</Location><CodePage>950</CodePage><LCID>1028</LCID><TimeZone>Taipei Standard Time</TimeZone><Bias>480</Bias><RunAsAdmin>true</RunAsAdmin><HookIME>true</HookIME><HookLCID>true</HookLCID></Profile>'",
     "        '<Profile Name=\"Run in Korean (Admin)\" Guid=\"44444444-4444-4444-4444-444444444444\"><Location>ko-KR</Location><CodePage>949</CodePage><LCID>1042</LCID><TimeZone>Korea Standard Time</TimeZone><Bias>540</Bias><RunAsAdmin>true</RunAsAdmin><HookIME>true</HookIME><HookLCID>true</HookLCID></Profile>'",
     "        '</Profiles></LRConfig>'",
     "    )",
-    "    Set-Content \"$dir\\LRConfig.xml\" -Value $content -Encoding Ascii",
+    "    Set-Content \"$persist_dir\\LRConfig.xml\" -Value $content -Encoding Ascii",
     "}"
 ],

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8af7d09 and f8b940b.

📒 Files selected for processing (1)

bucket/locale-remulator.json (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.

Learnt from: Lutra-Fs
Repo: ScoopInstaller/Extras PR: 16020
File: bucket/regedix.json:6-8
Timestamp: 2025-09-26T02:55:31.132Z
Learning: For Scoop manifests, prefer using "suggest" over "depends" for .NET runtime dependencies because user machines often have externally managed .NET runtimes already installed, and using "depends" could cause duplicate installations of the same runtime.

📚 Learning: 2025-10-19T13:58:23.389Z

Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.

Applied to files:

bucket/locale-remulator.json

🪛 GitHub Actions: Pull Requests

bucket/locale-remulator.json

[error] 1-1: Autoupdate failed: Could not update locale-remulator, hash for Locale_Remulator_1.6.0.zip failed!

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: WindowsPowerShell

🔇 Additional comments (2)

bucket/locale-remulator.json (2)

10-12: Good call using suggest for vcredist instead of depends (avoids forcing runtime installs).
Based on learnings, this matches common Extras repo guidance.

55-57: The checkver.github format is correct. Per the Scoop manifest schema, this field must be a full URI (e.g., https://github.com/owner/repo), not the shorthand owner/repo format. The code as shown is compliant.

bucket/locale-remulator.json

soleige · 2025-12-12T07:43:35Z

/verify

github-actions · 2025-12-12T07:44:39Z

All changes look good.

Wait for review from human collaborators.

locale-remulator

Check the full log for details.

locale-remulator: Add version 1.6.0

f8b940b

Add new manifest for Locale Remulator.

github-actions bot added the manifest-fix-needed label Dec 12, 2025

coderabbitai bot reviewed Dec 12, 2025

View reviewed changes

bucket/locale-remulator.json Show resolved Hide resolved

Fix URL format in locale-remulator.json

09f7eb0

github-actions bot added review-needed and removed manifest-fix-needed labels Dec 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

locale-remulator: Add version 1.6.0 #16778

locale-remulator: Add version 1.6.0 #16778

soleige commented Dec 12, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

soleige commented Dec 12, 2025

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

locale-remulator: Add version 1.6.0 #16778

Are you sure you want to change the base?

locale-remulator: Add version 1.6.0 #16778

Conversation

soleige commented Dec 12, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

github-actions bot commented Dec 12, 2025

locale-remulator

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

soleige commented Dec 12, 2025

Uh oh!

github-actions bot commented Dec 12, 2025

locale-remulator

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

soleige commented Dec 12, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 12, 2025 •

edited

Loading