-
Notifications
You must be signed in to change notification settings - Fork 411
Webpages: Improve screen reader navigation experience #8663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
DNin01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things to consider…
| "description": "A label used by screen readers." | ||
| }, | ||
| "enabledAddon": { | ||
| "message": "$1, add-on, on", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did I write the string like this?
- Some synthesizers mispronounce "addon" and it is technically a contraction of the full word "add-on", so that was used here.
- We usually refer to an addon's state as either "enabled" or "disabled", but Windows Narrator uses the term "disabled" to indicate a grayed-out control, so for distinction, I used "on" and "off" here.
| src="../../images/icons/help.svg" | ||
| class="icon-type setting-help-icon" | ||
| tabindex="-1" | ||
| :aria-labelledby="'setting-description-' + setting.id" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we have a graphic (image) whose label—alt text, essentially—is the full description of the setting. Is that right?
|
Great work! |
Changes
These changes are the start of improvements to screen reader accessibility.
Screen reader users will notice the following enhancements:
Let me know if I missed anything.
Commit summary
searchMsg.Tests
Tested with: