#153: remove support for python 3.8, add support for python 3.13. #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bandophahita
reviewed
Jul 9, 2025
bandophahita
reviewed
Jul 9, 2025
| def __init__(self, filepath: str, **kwargs: Any) -> None: # noqa: ANN401 | ||
| self.filepath = filepath | ||
| def __init__(self, filepath: Path | str, **kwargs: Any) -> None: # noqa: ANN401 | ||
| self.filepath = Path(filepath) |
There was a problem hiding this comment.
I'm wondering if narrator should get similar treatment for filepath?
bandophahita
reviewed
Jul 9, 2025
| the_narrator.clear_backup() | ||
| return | ||
|
|
||
| # type: ignore[method-assign] |
bandophahita
reviewed
Jul 9, 2025
| field_name, | ||
| field, | ||
| field_value, | ||
| value_is_complex=value_is_complex, |
There was a problem hiding this comment.
COM812 makes black do this. ew
bandophahita
reviewed
Jul 9, 2025
|
I think we ought to ignore COM812 - missing trailing commas. It's benefit hardly outweighs the ugly formatting that occurs with Black. |
|
We are removing the pre-commit. We also need to update the readme and remove the step that says to run |
bandophahita
previously approved these changes
Jul 23, 2025
bandophahita
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is large, but it just applies the changes from the updated
ruff,black, andmypyrules now that we no longer support Python 3.8 (and whatever updates they included). It is mostly mechanical, but there were a couple "functional" (i.e. syntactic sugar) changes to abide by some ofruff's andmypy's rules.