Skip to content

Code refactor #8426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 16, 2020
Merged

Code refactor #8426

merged 11 commits into from
Jun 16, 2020

Conversation

@raju249
Copy link
Member

@raju249 raju249 commented Jun 16, 2020 •
edited
Loading

Description

This PR adds the following improvements:

  1. Adds a getClass to config which returns the class based on the implementation option.
  2. Adds a create(Config config) method to distributor.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AutomatedTester
Copy link
Member

AutomatedTester commented Jun 16, 2020

merging as the failures don't look related. Chrome seems incredibly volatile in the run

@AutomatedTester AutomatedTester merged commit 6a73b28 into SeleniumHQ:master Jun 16, 2020
@raju249 raju249 deleted the code-refactor branch June 17, 2020 05:15
titusfortner pushed a commit to titusfortner/selenium that referenced this pull request Aug 13, 2020
@raju249 @AutomatedTester @titusfortner
Add getDistributor based on implementaion required (SeleniumHQ#8426)
63c926c 
* Add getDistributor based on implementaion required

* Resolve deps for new getDistributor method

* Update deps

* Change variable class name

* Add Remote Distributor as default class

* Add getClass method

* Remove unused imports

* Update getClass method

* Use getClass for EventBus implementation

* Create RemoteDistributor inline for RouterServer

Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raju249 @AutomatedTester