Skip to content

[JS] Allow relativeby with findElement #9396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2021
Merged

[JS] Allow relativeby with findElement #9396

merged 4 commits into from
Apr 20, 2021

Conversation

@harsha509
Copy link
Member

@harsha509 harsha509 commented Apr 19, 2021 •
edited
Loading

Description

Allow RelativeBy to work with findElement.

  • Returns: first resolved element from array of elements
  • throws: NoSuchElementError if no element is found

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AutomatedTester AutomatedTester merged commit 68f3edc into SeleniumHQ:trunk Apr 20, 2021
pujagani pushed a commit to pujagani/selenium that referenced this pull request Apr 21, 2021
@harsha509 @pujagani
[JS] Allow relativeby with findElement (SeleniumHQ#9396)
5487013 
* [JS] Allow relativeby with findElement

* [js] resolves custom locator issue triggered by previous change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AutomatedTester AutomatedTester AutomatedTester approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harsha509 @AutomatedTester