Ladybird: Add open file item to menu... #19048
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADKaster
requested changes
May 29, 2023
Member
ADKaster
left a comment
There was a problem hiding this comment.
This looks pretty good Xexxa! A couple things to change though.
Collaborator
Author
Thanks a lot for the review and explaining pedagogically what I needed to do! Now I know how to write local variables and have a marginally better understanding of instances and what the slots-thingy do. 😅 |
Member
|
Code reviewed in person & pushed directly to master due to GitHub being weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do have drag and drop to open local files but I like the Ctrl+O option to open file dialog.
All my browser have this functionality (Chromium, Firefox, Netsurf, Doodle, Edge, Vivaldi).
This is probably my biggest code contribution so far and I do not have a firm grasp of C++ yet so check the code before a possible merge. :^)
Also added two separators(the "File" separator has the same position as in Ladybird SerenityOS, the "Edit" separator just made sense).