Document and test MSRV #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this. When I migrated to actions I also added a check for the MSRV for the 1.0 version of the crate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, and thanks for the library! I'm the maintainer of
pretty_assertions, and am looking and moving fromansi_termtoyansi. I couldn't find a documented MSRV, but the build failures point to 1.54.0 as a likely candidate (stabilization ofextended_key_value_attributes).This PR documents the MSRV and adds it to CI, along with a proposed policy (updating MSRV on minor versions is pretty standard I think?).
Let me know if you think this is okay, or if any updates are required. I'd like to know what your thoughts are on frequency of the MSRV being updated?