[1/6 Deps Update] Remove Existing Locked Deps. #396

svij-sc · 2025-11-25T22:12:39Z

Background Context: #405
Some guidance on stack of PRs: #405 (comment)

Scope of PR

This PR simply removes the existing locked dep files - which will no longer be needed in uv world as uv maintains its own global lock file: https://docs.astral.sh/uv/concepts/projects/sync/

This reverts commit 4137907.

This reverts commit 7fbeb58.

kmontemayor2-sc

Should we also remove the ways to build these files in this PR?

GiGL/Makefile

Lines 97 to 137 in 7a66a06

    
           # Can only be run on an arm64 mac, otherwise generated hashed req file will be wrong 
        
           generate_mac_arm64_cpu_hashed_requirements: 
        
           	pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \ 
        
           	--output-file=requirements/darwin_arm64_requirements_unified.txt \ 
        
           	--extra torch25-cpu --extra transform --extra experimental \ 
        
           	./python/pyproject.toml 
        
           # Can only be run on an arm64 mac, otherwise generated hashed req file will be wrong. 
        
           generate_dev_mac_arm64_cpu_hashed_requirements: 
        
           	pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \ 
        
           	--output-file=requirements/dev_darwin_arm64_requirements_unified.txt \ 
        
           	--extra torch25-cpu --extra transform --extra dev --extra experimental \ 
        
           	./python/pyproject.toml 
        
           # Can only be run on linux, otherwise generated hashed req file will be wrong. 
        
           generate_linux_cpu_hashed_requirements: 
        
           	pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \ 
        
           	--output-file=requirements/linux_cpu_requirements_unified.txt \ 
        
           	--extra torch25-cpu --extra transform --extra experimental \ 
        
           	./python/pyproject.toml 
        
           # Can only be run on linux, otherwise generated hashed req file will be wrong. 
        
           generate_dev_linux_cpu_hashed_requirements: 
        
           	pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \ 
        
           	--output-file=requirements/dev_linux_cpu_requirements_unified.txt \ 
        
           	--extra torch25-cpu --extra transform --extra dev --extra experimental \ 
        
           	./python/pyproject.toml 
        
           # Can only be run on linux, otherwise generated hashed req file will be wrong. 
        
           generate_linux_cuda_hashed_requirements: 
        
           	pip-compile  -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \ 
        
           	--output-file=requirements/linux_cuda_requirements_unified.txt \ 
        
           	--extra torch25-cuda-121 --extra transform --extra experimental \ 
        
           	./python/pyproject.toml 
        
           # Can only be run on linux, otherwise generated hashed req file will be wrong. 
        
           generate_dev_linux_cuda_hashed_requirements: 
        
           	pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \ 
        
           	--output-file=requirements/dev_linux_cuda_requirements_unified.txt \ 
        
           	--extra torch25-cuda-121 --extra transform --extra dev --extra experimental \ 
        
           	./python/pyproject.toml

svij-sc · 2025-12-02T05:27:01Z

@kmontemayor2-sc

Should we also remove the ways to build these files in this PR?

GiGL/Makefile

Lines 97 to 137 in 7a66a06

# Can only be run on an arm64 mac, otherwise generated hashed req file will be wrong

generate_mac_arm64_cpu_hashed_requirements:

pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \

--output-file=requirements/darwin_arm64_requirements_unified.txt \

--extra torch25-cpu --extra transform --extra experimental \

./python/pyproject.toml

# Can only be run on an arm64 mac, otherwise generated hashed req file will be wrong.

generate_dev_mac_arm64_cpu_hashed_requirements:

pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \

--output-file=requirements/dev_darwin_arm64_requirements_unified.txt \

--extra torch25-cpu --extra transform --extra dev --extra experimental \

./python/pyproject.toml

# Can only be run on linux, otherwise generated hashed req file will be wrong.

generate_linux_cpu_hashed_requirements:

pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \

--output-file=requirements/linux_cpu_requirements_unified.txt \

--extra torch25-cpu --extra transform --extra experimental \

./python/pyproject.toml

# Can only be run on linux, otherwise generated hashed req file will be wrong.

generate_dev_linux_cpu_hashed_requirements:

pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \

--output-file=requirements/dev_linux_cpu_requirements_unified.txt \

--extra torch25-cpu --extra transform --extra dev --extra experimental \

./python/pyproject.toml

# Can only be run on linux, otherwise generated hashed req file will be wrong.

generate_linux_cuda_hashed_requirements:

pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \

--output-file=requirements/linux_cuda_requirements_unified.txt \

--extra torch25-cuda-121 --extra transform --extra experimental \

./python/pyproject.toml

# Can only be run on linux, otherwise generated hashed req file will be wrong.

generate_dev_linux_cuda_hashed_requirements:

pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \

--output-file=requirements/dev_linux_cuda_requirements_unified.txt \

--extra torch25-cuda-121 --extra transform --extra dev --extra experimental \

./python/pyproject.toml

I did it in 3/6 https://github.com/Snapchat/GiGL/pull/398/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52

Hope thats okay too!

kmontemayor2-sc · 2025-12-02T17:43:56Z

I did it in 3/6 https://github.com/Snapchat/GiGL/pull/398/files#diff 76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52

Since we're planning on putting in the whole stack together(?) this is fine with me :)

This PR is fine but holding off on stamping until everything is ready.

kmontemayor2-sc · 2025-12-02T17:44:59Z

Actually - is there a reason you don't want to merge this into main?

svij-sc · 2025-12-02T18:49:26Z

Actually - is there a reason you don't want to merge this into main?

I may need to address conflicts, and need to do final scale testing. Thus, holding off merging into main.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kyle Montemayor <kmontemayor2@snapchat.com>

svij-sc added 3 commits November 25, 2025 22:07

remove lock files

ce85460

move files

7fbeb58

update

4137907

svij-sc changed the title ~~Remove Existing Deps~~ Remove Existing Locked Deps. Nov 25, 2025

svij-sc added 2 commits November 25, 2025 22:16

Revert "update"

40d92ef

This reverts commit 4137907.

Revert "move files"

92a0b0d

This reverts commit 7fbeb58.

svij-sc changed the title ~~Remove Existing Locked Deps.~~ [1/4 Deps Update] Remove Existing Locked Deps. Nov 26, 2025

svij-sc changed the title ~~[1/4 Deps Update] Remove Existing Locked Deps.~~ [1/6 Deps Update] Remove Existing Locked Deps. Nov 26, 2025

kmontemayor2-sc reviewed Nov 26, 2025

View reviewed changes

svij-sc mentioned this pull request Dec 2, 2025

Update deps / python to latest supported version - use UV for dep management #405

Open

yliu2-sc approved these changes Dec 3, 2025

View reviewed changes

kmontemayor2-sc approved these changes Dec 3, 2025

View reviewed changes

[2/6 Deps Update] Udate deps --> migrate uv (#397)

2166778

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kyle Montemayor <kmontemayor2@snapchat.com>

svij-sc marked this pull request as ready for review December 13, 2025 01:55

svij-sc requested review from mkolodner-sc, nshah-sc, xgao4-sc and zfan3-sc as code owners December 13, 2025 01:55

svij-sc merged commit 7b906b4 into svij/feature-uv-update-deps Dec 13, 2025
6 checks passed

svij-sc deleted the svij/remove-existing-deps branch December 13, 2025 01:55

svij-sc mentioned this pull request Dec 13, 2025

Update deps / python to latest supported version - use UV for dep management #414

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[1/6 Deps Update] Remove Existing Locked Deps. #396

[1/6 Deps Update] Remove Existing Locked Deps. #396

Uh oh!

svij-sc commented Nov 25, 2025 •

edited

Loading

Uh oh!

kmontemayor2-sc left a comment

Uh oh!

svij-sc commented Dec 2, 2025 •

edited

Loading

Uh oh!

kmontemayor2-sc commented Dec 2, 2025

Uh oh!

kmontemayor2-sc commented Dec 2, 2025

Uh oh!

svij-sc commented Dec 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	# Can only be run on an arm64 mac, otherwise generated hashed req file will be wrong
	generate_mac_arm64_cpu_hashed_requirements:
	pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \
	--output-file=requirements/darwin_arm64_requirements_unified.txt \
	--extra torch25-cpu --extra transform --extra experimental \
	./python/pyproject.toml

	# Can only be run on an arm64 mac, otherwise generated hashed req file will be wrong.
	generate_dev_mac_arm64_cpu_hashed_requirements:
	pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \
	--output-file=requirements/dev_darwin_arm64_requirements_unified.txt \
	--extra torch25-cpu --extra transform --extra dev --extra experimental \
	./python/pyproject.toml

	# Can only be run on linux, otherwise generated hashed req file will be wrong.
	generate_linux_cpu_hashed_requirements:
	pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \
	--output-file=requirements/linux_cpu_requirements_unified.txt \
	--extra torch25-cpu --extra transform --extra experimental \
	./python/pyproject.toml

	# Can only be run on linux, otherwise generated hashed req file will be wrong.
	generate_dev_linux_cpu_hashed_requirements:
	pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \
	--output-file=requirements/dev_linux_cpu_requirements_unified.txt \
	--extra torch25-cpu --extra transform --extra dev --extra experimental \
	./python/pyproject.toml

	# Can only be run on linux, otherwise generated hashed req file will be wrong.
	generate_linux_cuda_hashed_requirements:
	pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \
	--output-file=requirements/linux_cuda_requirements_unified.txt \
	--extra torch25-cuda-121 --extra transform --extra experimental \
	./python/pyproject.toml

	# Can only be run on linux, otherwise generated hashed req file will be wrong.
	generate_dev_linux_cuda_hashed_requirements:
	pip-compile -v --allow-unsafe --generate-hashes --no-emit-index-url --resolver=backtracking \
	--output-file=requirements/dev_linux_cuda_requirements_unified.txt \
	--extra torch25-cuda-121 --extra transform --extra dev --extra experimental \
	./python/pyproject.toml

[1/6 Deps Update] Remove Existing Locked Deps. #396

[1/6 Deps Update] Remove Existing Locked Deps. #396

Uh oh!

Conversation

svij-sc commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kmontemayor2-sc left a comment

Choose a reason for hiding this comment

Uh oh!

svij-sc commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kmontemayor2-sc commented Dec 2, 2025

Uh oh!

kmontemayor2-sc commented Dec 2, 2025

Uh oh!

svij-sc commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

svij-sc commented Nov 25, 2025 •

edited

Loading

svij-sc commented Dec 2, 2025 •

edited

Loading

svij-sc commented Dec 2, 2025 •

edited

Loading