Add some nominal types for representing algebra elements #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dalcde Feedback appreciated |
Contributor
|
Some minor comments:
1. This is very much a matter of style but I'd prefer if we made the
degree/index fields of BasisElem public instead of having
getter/setters.
2. I would expect to use BasisElem etc. for modules as well as algebras.
Is algebras the best place to put it?
3. Do we use the partial ordering on BasisElem etc. anywhere?
4. I'm pretty sure this is true but we should make sure the branches are
optimized away when we apply `multiply` to `BasisElem` and
`VectorElem`. Otherwise I like this ergonomic improvement a lot.
|
Contributor
Author
|
Just an update; I've been super hosed the last weeks and have been punting on this since I haven't been approaching this a great way. I think I'll take a look at redoing this by adding a separate, parallel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP, since I expect it to tear up a lot of function signatures in
algebra,sseq, andext. I'm pushing it now to get feedback on the design.