Fix update not working bug#161
Open
Lloyd26 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, clicking the update button in SPX Solo v.1.4.0 does nothing as it does not update the template. This bug is not present in v.1.3.0.
The bug is fixed by setting the default value of
projectFormatfrom'OGRAF'to'SPX'. Prior to this change, it will callupdateItem(), but it will result into an error sincedocument.getElementById('datafile')isnull. Updating in SPX format doesn't need to callupdateItem()as it will call the template's own update handler function, which fixes the problem.Additionally, I noticed through observation that the default value of
projectFormatincase 'nextTemplate'andcase 'stopTemplate'is set to'SPX', so I also set the default value incase 'updateTemplate'to'SPX', and the problem is fixed.