Fix convex function ignoring given properties #2765
Conversation
smallsaucepan
left a comment
There was a problem hiding this comment.
Thanks for this @kareemjeiroudi. Just a request for a minor change to test.ts and we should be good to go!
51adb21 to
e17d2cb
Compare
e17d2cb to
1454744
Compare
|
I had to rebase on master |
|
Hi @kareemjeiroudi would like to merge this PR but can't bring it up to date with master first. Do you know if you have "Allow edits by maintainers" disabled on your branch / repo? |
|
Hi all, are there any plans to get this merged? I can submit another PR to resolve this if necessary. |
|
That would actually be a huge help thanks @blchelle. I know it's not a massive PR, though could you please include both yourself and @kareemjeiroudi in the author list? That seems most fair. |
|
Thanks @smallsaucepan, I have put up the PR. Let me know if anything needs to be changed. |
1454744 to
feead38
Compare
|
Hi everyone, apologies for not actively updating this PR. Thanks @blchelle for taking over. @smallsaucepan I'll close this PR, as soon as the other PR is merged 👍. |
51b50f8 to
5b11943
Compare
@smallsaucepan I've just rebased the branch on master and checked "Allow edits and access to secrets by maintainers" |
Background
Using the
convexfunction to combine a feature collection returns a newly constructed polygon with missing properties. This is crucial if the caller of the function attempts to pass additional properties to the end polygon.PR includes a test to test this scenario and improved typing
Resolve #2762
This change fixes a bug where the convex function ignores given properties. I came across this problem, as I was working on a project for one of our clients