feat(client): Add ssh private-key support#1390
Merged
Merged
Conversation
TwiN
approved these changes
Nov 16, 2025
Owner
|
Excellent work! I'd appreciate a test for the private key, as you've suggested, though, and then we're good to go! No need to make it super complex. |
Contributor
Author
|
I looked into what we could be testing here. I've added a few cases to the existing config testing. But I can't think of a way to implement proper integration testing. Password-only could maybe be verified using https://test.rebex.net/ but can't think of a decent way to test private key auth. |
TwiN
approved these changes
Nov 18, 2025
Contributor
Author
|
@TwiN I think the tests failed due to GitHub facing issues. Could you try re-running the tests? |
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Nov 24, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/twin/gatus](https://github.com/TwiN/gatus) | minor | `v5.31.0` -> `v5.33.0` | --- ### Release Notes <details> <summary>TwiN/gatus (ghcr.io/twin/gatus)</summary> ### [`v5.33.0`](https://github.com/TwiN/gatus/releases/tag/v5.33.0) [Compare Source](TwiN/gatus@v5.32.0...v5.33.0) #### What's Changed - feat(client): Add ssh private-key support by [@​mufeedali](https://github.com/mufeedali) in [#​1390](TwiN/gatus#1390) #### New Contributors - [@​mufeedali](https://github.com/mufeedali) made their first contribution in [#​1390](TwiN/gatus#1390) **Full Changelog**: <TwiN/gatus@v5.32.0...v5.33.0> ### [`v5.32.0`](https://github.com/TwiN/gatus/releases/tag/v5.32.0) [Compare Source](TwiN/gatus@v5.31.0...v5.32.0) #### What's Changed - feat(ui): customizable dashboard heading and subheading by [@​RezeOW](https://github.com/RezeOW) in [#​1235](TwiN/gatus#1235) - docs: Add note to README.md regarding CAP\_NET\_RAW by [@​h3mmy](https://github.com/h3mmy) in [#​1384](TwiN/gatus#1384) #### New Contributors - [@​RezeOW](https://github.com/RezeOW) made their first contribution in [#​1235](TwiN/gatus#1235) **Full Changelog**: <TwiN/gatus@v5.31.0...v5.32.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi41LjAiLCJ1cGRhdGVkSW5WZXIiOiI0Mi41LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImltYWdlIl19--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/2110 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1257
Summary
Adds support for using an unencrypted SSH key for SSH endpoint testing. Closes #1257 . I don't know if I should be adding a separate test for private-key, please let me know if I should :)
Checklist
README.md, if applicable.