fix(test): Remove t.Parallel() from tests racing on injectedHTTPClient#1630
Merged
Conversation
…Client Agent-Logs-Url: https://github.com/TwiN/gatus/sessions/bd8f2b87-d453-4653-a61d-4bf4dda4024b Co-authored-by: TwiN <15699766+TwiN@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
TwiN
April 19, 2026 00:02
View session
TwiN
approved these changes
Apr 19, 2026
doonga
pushed a commit
to greyrock-labs/home-ops
that referenced
this pull request
May 20, 2026
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/twin/gatus](https://github.com/TwiN/gatus) | minor | `v5.35.0` → `v5.36.0` | --- ### Release Notes <details> <summary>TwiN/gatus (ghcr.io/twin/gatus)</summary> ### [`v5.36.0`](https://github.com/TwiN/gatus/releases/tag/v5.36.0) [Compare Source](TwiN/gatus@v5.35.0...v5.36.0) ##### What's Changed - perf: Add PostgreSQL indexes for \~15x performance improvement by [@​ozanonurtek](https://github.com/ozanonurtek) in [#​1541](TwiN/gatus#1541) - fix(alerting): Remove square brackets from email subject by [@​jaydeethree](https://github.com/jaydeethree) in [#​1586](TwiN/gatus#1586) - fix(security): Do not allow invalid security configs by [@​PythonGermany](https://github.com/PythonGermany) in [#​1531](TwiN/gatus#1531) - fix: return error from rdapQuery when no expiration event found by [@​majiayu000](https://github.com/majiayu000) in [#​1603](TwiN/gatus#1603) - fix(ci): regenerate-static-assets workflow reporting false errors on success by [@​Copilot](https://github.com/Copilot) in [#​1614](TwiN/gatus#1614) - feat(ui): Add customizable OIDC login screen branding by [@​hluaces](https://github.com/hluaces) in [#​1583](TwiN/gatus#1583) - fix(test): Remove t.Parallel() from tests racing on injectedHTTPClient by [@​Copilot](https://github.com/Copilot) in [#​1630](TwiN/gatus#1630) - fix(storage): close rows before nested queries to prevent PostgreSQL driver error by [@​osalloum](https://github.com/osalloum) in [#​1503](TwiN/gatus#1503) - docs: Document remote.client configuration by [@​surdaft](https://github.com/surdaft) in [#​1637](TwiN/gatus#1637) - fix: update lib/pq to v1.11.2 to fix Supabase PostgreSQL connection regression by [@​wahajahmed010](https://github.com/wahajahmed010) in [#​1644](TwiN/gatus#1644) ##### New Contributors - [@​ozanonurtek](https://github.com/ozanonurtek) made their first contribution in [#​1541](TwiN/gatus#1541) - [@​jaydeethree](https://github.com/jaydeethree) made their first contribution in [#​1586](TwiN/gatus#1586) - [@​majiayu000](https://github.com/majiayu000) made their first contribution in [#​1603](TwiN/gatus#1603) - [@​hluaces](https://github.com/hluaces) made their first contribution in [#​1583](TwiN/gatus#1583) - [@​osalloum](https://github.com/osalloum) made their first contribution in [#​1503](TwiN/gatus#1503) - [@​surdaft](https://github.com/surdaft) made their first contribution in [#​1637](TwiN/gatus#1637) - [@​wahajahmed010](https://github.com/wahajahmed010) made their first contribution in [#​1644](TwiN/gatus#1644) **Full Changelog**: <TwiN/gatus@v5.35.0...v5.36.0> </details> --- ### Configuration 📅 **Schedule**: (in timezone America/New_York) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xODIuMiIsInVwZGF0ZWRJblZlciI6IjQzLjE4Mi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19--> Reviewed-on: https://git.greyrock.io/greyrock-labs/home-ops/pulls/82
eleboucher
pushed a commit
to eleboucher/homelab
that referenced
this pull request
May 20, 2026
…(#577) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/twin/gatus](https://github.com/TwiN/gatus) | minor | `v5.35.0` → `v5.36.0` | --- ### Release Notes <details> <summary>TwiN/gatus (ghcr.io/twin/gatus)</summary> ### [`v5.36.0`](https://github.com/TwiN/gatus/releases/tag/v5.36.0) [Compare Source](TwiN/gatus@v5.35.0...v5.36.0) ##### What's Changed - perf: Add PostgreSQL indexes for \~15x performance improvement by [@​ozanonurtek](https://github.com/ozanonurtek) in [#​1541](TwiN/gatus#1541) - fix(alerting): Remove square brackets from email subject by [@​jaydeethree](https://github.com/jaydeethree) in [#​1586](TwiN/gatus#1586) - fix(security): Do not allow invalid security configs by [@​PythonGermany](https://github.com/PythonGermany) in [#​1531](TwiN/gatus#1531) - fix: return error from rdapQuery when no expiration event found by [@​majiayu000](https://github.com/majiayu000) in [#​1603](TwiN/gatus#1603) - fix(ci): regenerate-static-assets workflow reporting false errors on success by [@​Copilot](https://github.com/Copilot) in [#​1614](TwiN/gatus#1614) - feat(ui): Add customizable OIDC login screen branding by [@​hluaces](https://github.com/hluaces) in [#​1583](TwiN/gatus#1583) - fix(test): Remove t.Parallel() from tests racing on injectedHTTPClient by [@​Copilot](https://github.com/Copilot) in [#​1630](TwiN/gatus#1630) - fix(storage): close rows before nested queries to prevent PostgreSQL driver error by [@​osalloum](https://github.com/osalloum) in [#​1503](TwiN/gatus#1503) - docs: Document remote.client configuration by [@​surdaft](https://github.com/surdaft) in [#​1637](TwiN/gatus#1637) - fix: update lib/pq to v1.11.2 to fix Supabase PostgreSQL connection regression by [@​wahajahmed010](https://github.com/wahajahmed010) in [#​1644](TwiN/gatus#1644) ##### New Contributors - [@​ozanonurtek](https://github.com/ozanonurtek) made their first contribution in [#​1541](TwiN/gatus#1541) - [@​jaydeethree](https://github.com/jaydeethree) made their first contribution in [#​1586](TwiN/gatus#1586) - [@​majiayu000](https://github.com/majiayu000) made their first contribution in [#​1603](TwiN/gatus#1603) - [@​hluaces](https://github.com/hluaces) made their first contribution in [#​1583](TwiN/gatus#1583) - [@​osalloum](https://github.com/osalloum) made their first contribution in [#​1503](TwiN/gatus#1503) - [@​surdaft](https://github.com/surdaft) made their first contribution in [#​1637](TwiN/gatus#1637) - [@​wahajahmed010](https://github.com/wahajahmed010) made their first contribution in [#​1644](TwiN/gatus#1644) **Full Changelog**: <TwiN/gatus@v5.35.0...v5.36.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/577
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestGetHTTPClientandTestHttpClientProvidesOAuth2BearerTokenboth callt.Parallel()while concurrently reading/writing the package-levelinjectedHTTPClientglobal, triggering the-racedetector and causing cascading test failures.Changes
client/client_test.go: Removet.Parallel()fromTestGetHTTPClientandTestHttpClientProvidesOAuth2BearerToken— these tests mutate a shared global and must not run concurrently.