Fix integer overflow and underflow bugs in arithmetic helper functions#163
Merged
Merged
Conversation
Owner
|
What's the point of those |
…ed and remove constexpr where C++14-only
…ed and remove constexpr where C++14-only
Contributor
Author
|
I agree the |
Owner
|
Much better. Thanks for making those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes integer overflow and underflow issues in
SafeAddandSafeMultiply, and introducesSafeSubandSafeNegwith comprehensive regression test coverage.Changes
args.hxxSafeAddandSafeMultiplywith proper signed and unsigned handlingSafeSubfor subtraction overflow and underflow protectionSafeNegfor safe negation withINT_MINoverflow handlingstd::make_unsigned_t<T>test/safe_arithmetic.cxxImpact
Eliminates undefined behavior in arithmetic operations used by argument parsing and input-sensitive code paths.