Skip to content

fix: ensure tool calls are accumulated in streaming responses #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sxy-trans-n merged 1 commit into from
Jul 31, 2025
Merged

fix: ensure tool calls are accumulated in streaming responses #70

sxy-trans-n merged 1 commit into from
Jul 31, 2025

Conversation

@sxy-trans-n
Copy link
Collaborator

@sxy-trans-n sxy-trans-n commented Jul 31, 2025

  • Always accumulate tool calls to return value regardless of callback presence
  • Fixes finish_reason being incorrectly set to "stop" instead of "tool_calls"
    in streaming mode when tools are called
  • Maintains backward compatibility for non-streaming responses

#50

syh-trans-n
syh-trans-n approved these changes Jul 31, 2025
View reviewed changes
Copy link
Collaborator

@syh-trans-n syh-trans-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@sxy-trans-n sxy-trans-n merged commit 7d39ed8 into main Jul 31, 2025
2 checks passed
@sxy-trans-n sxy-trans-n deleted the fix/streaming-toolcalls-accumulation branch July 31, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syh-trans-n syh-trans-n syh-trans-n approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sxy-trans-n @syh-trans-n