Docs brush up#159
Conversation
|
Thank you, I'll take a look soon. I wanted to continue polishing it to a standard over the week. you read my mind haha. |
|
Yeah, not much changes in the content here. If there are actual new or changed things, you can add that. |
|
|
||
| - `LaunchUnderMouse` default is **false**, can be used to launch the Hurl window under the mouse when enabled | ||
| - `MinimizeOnFocusLoss` default is **true** | ||
| - `NoWhiteBorder` set **true** or **false** to enable or disable the white border around the window |
There was a problem hiding this comment.
This should be looked at: do you show or hide the border? And is it even there in the latest UI?
There was a problem hiding this comment.
show or hide the border?
Yes, the one around the select browser window
There was a problem hiding this comment.
I mean: true = show or true = hide?
There was a problem hiding this comment.
Oh I see, I worded it confusing.
true=hide
|
|
||
| ## Installation | ||
|
|
||
| To use it in Chrome, follow the steps below: |
There was a problem hiding this comment.
These steps seem to be seriously outdated?
There was a problem hiding this comment.
I updated them recently. If anything, I might have missed on adding a step in middle.
There was a problem hiding this comment.
I think I know why I can't find Dev Mode - I already have it on 😆
This is used by inno setup as a pre-install message.
I think extension readme is fine as it is, whether moving it under Docs is something to consider, including Hurl local development docs.
I will probably remove SECURITY.md, I don't know why I added it in the first place |
| # Hurl | ||
|
|
||
| <h1 align="center">Hurl</h1> | ||
| A Windows utility that lets you choose a browser on the click of a link. | ||
|
|
||
| <p align="center">A windows utility that lets you choose a browser on the click of a link</p> | ||
|  |
There was a problem hiding this comment.
I prefer the Icon/Logo is either centered or in a two column layout as it was previously.
So you can leave it as it was earlier. but open to any suggestions here
There was a problem hiding this comment.
By default, all text in Markdown fields are aligned to the left. A Markdown image inside HTML tags does not work. In general, HTML is unrecommended anyway. More info: https://github.github.com/gfm/#html-blocks
Compare these images
and
Notice the second URI isn't underlined and how hovering over it doesn't offer to open the file. The result is:
Options
- Leave the Markdown image as it is, and left-align the links to match
- Many other ReadMe files (in other repositories) use a very wide "hero image" that will almost always span the available/maximum width. If you want that, you'll have to make such an image first. Examples: WinUI Gallery, PowerToys, Files.
- Back to using HTML
There was a problem hiding this comment.
Let's currently go with 3 (I made additional few tweaks) for now. And will come back to 2. later once we have a fresh icon for hurl
This reverts commit 8af603c.
|
I merged your PR, if there's anything more you can open additional PRs. Thanks once again. I will also take note of some discussion and things you mentioned |
General brush up of some MD files. Improving sentences/spelling, markdown formatting, using "images" folder.
Using a few guides from https://learn.microsoft.com/contribute/content/markdown-reference.
Notes (for later)
Hurl/Docs/Edit-UserSettingsjson.md
Line 98 in 7c2d07b
MinimizeOnFocusLoss)