Fix hidden browsers showing up in Select window#164
Merged
Conversation
U-C-S
requested changes
Sep 20, 2024
Owner
U-C-S
left a comment
There was a problem hiding this comment.
Thanks for the PR, didn't realize I had broken this option.
This reverts commit fca73eb.
U-C-S
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, in Hurl v0.9.0, there's an issue where the if you set a browser as hidden, it would still shows up.
So this PR, fixes the issue by not including the hidden browsers in the browser selector screen. Thanks.