Allow fog compute from points other than Viewpoint position#1400
Open
dileepvr wants to merge 2 commits into
Open
Allow fog compute from points other than Viewpoint position#1400dileepvr wants to merge 2 commits into
dileepvr wants to merge 2 commits into
Conversation
…sition. In this commit, camera actor's ViewPos field has to be non-null to activate. Sets FogCenterPos to camera->tracer if not null, else tries to undo ViewPos offset and sets FogCenterPos that way (unless VPSF_ABSOLUTEPOS flag is set).
Thanks for opening this PR! We'll review it soon.I'm a bot that checks for some common problems. I'll update this comment with anything I find. Nothing to report. Nice :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability to compute fog from a point different from Viewpoint position. Useful for third-person cameras, cinematic cameras with far-away subject emphasis, etc.
Orthographic example with thickfog enabled:
viewpos_thickfog.zip
fogcenter2.mp4
We need to decide on whether or not to add a flag to the camera actor to activate this.
In the first commit, camera actor's
ViewPosfield has to be non-nullto activate. SetsViewpoint.FogCenterPostocamera->tracerif notnull, else tries to undoViewPosoffset and setsViewpoint.FogCenterPosthat way (unlessVPSF_ABSOLUTEPOSflag is set).Works with all manner of portals and even in camera textures.
Checklist