Skip to content

MST-9510: clarify Slack weather HTTP output paths#794

Open
tmatup wants to merge 1 commit into
mainfrom
fix-MST-9510
Open

MST-9510: clarify Slack weather HTTP output paths#794
tmatup wants to merge 1 commit into
mainfrom
fix-MST-9510

Conversation

@tmatup
Copy link
Copy Markdown
Member

@tmatup tmatup commented May 15, 2026

Summary

  • Clarify that the Slack office topic should be normalized to Bellevue before geocoding.
  • Document the .output.body paths for chaining geocode and weather HTTP responses.

Run evidence

Latest e2e run 2026-05-15_07-29-17 showed skill-flow-slack-weather-pipeline now reaches Slack and geocoding, but the generated weather request used $vars.geocodeCity.output.results[0]... instead of $vars.geocodeCity.output.body.results[0]....

Jira: https://uipath.atlassian.net/browse/MST-9510

Verification

  • TaskDefinition YAML validation for the edited task YAML.
  • git diff --check.

Prompt the Slack weather pipeline task to normalize the office address to Bellevue and to chain HTTP response JSON through .output.body paths.

Verified with TaskDefinition YAML validation and diff whitespace checks.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

Claude finished @tmatup's task in 1m 14s —— View job


PR Review: MST-9510 — clarify Slack weather HTTP output paths

  • Read review criteria and project conventions
  • Read existing PR conversation
  • Analyze full diff against origin/main
  • Read full changed file for surrounding context
  • Check for cross-skill references, secrets, broken links
  • Post review findings

Summary

Adds hints to the slack_weather_pipeline test task's initial_prompt clarifying that (1) the Slack channel address should be normalized to "Bellevue" before geocoding, and (2) HTTP action results must be read from .output.body (not .output directly). Motivated by an e2e run where the agent used $vars.geocodeCity.output.results[0]... instead of the correct $vars.geocodeCity.output.body.results[0]....

Change-by-Change Review

1. tests/tasks/uipath-maestro-flow/multi_node/slack_weather_pipeline/slack_weather_pipeline.yaml — lines 24-30

Severity: Low

The change is correct and well-scoped — it addresses a documented e2e failure by adding structural hints about the HTTP response data model (.output.body path).

One consideration: the added text prescribes specific variable names (geocodeCity, fetchWeather) and exact JSON paths (results[0].latitude, current.temperature_2m). This makes the prompt more prescriptive than the general guidance in code_review.md prefers ("initial_prompt is minimal — describes the goal, not the steps"). However, this is a pragmatic fix for a structural issue (the agent doesn't know the runtime's HTTP response envelope shape), and the existing prompt was already directive. Acceptable for unblocking the e2e pipeline.

No issues with:

  • YAML syntax — valid
  • No env_packages added (correct per task-authoring rules)
  • No secrets or personal paths
  • No cross-skill references
  • Scoped to the single task being fixed

What's Missing

Nothing identified.

Area Ratings

Area Status Notes
Frontmatter OK Unchanged, valid
E2E Tests OK Existing task modified, success criteria unchanged
Skill Body N/A No skill files changed
References & Assets N/A No reference files changed
Repo Hygiene OK No secrets, no cross-skill refs, scoped change

Issues for Manual Review

  • Verify that the open-meteo geocoding API actually returns results under results[0].latitude / results[0].longitude and that the weather endpoint returns current.temperature_2m — these are domain-specific paths the reviewer should confirm against the open-meteo API docs.
  • Confirm that the flow runtime's HTTP action does wrap responses under .output.body — this is the core assumption the fix relies on.

Conclusion

Clean, focused fix addressing a real e2e failure. No blocking issues. Approve.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

Claude finished @tmatup's task in 1m 53s —— View job


Coder-eval task lint (advisory)

1 task YAML changed; verdicts: 0 Critical, 0 High, 1 Medium, 0 Low, 0 OK.

Rubric: .claude/commands/lint-task.md. This check is advisory and never blocks merge.

Evidence of passing run

High — PR body describes the e2e run (2026-05-15_07-29-17) that motivated the fix (wrong .output.results[0] path), but does not claim the task passes after these prompt changes. Please edit the PR description to add a line like:

Ran skill-flow-slack-weather-pipeline locally and it passed.

Per-task lint

tests/tasks/uipath-maestro-flow/multi_node/slack_weather_pipeline/slack_weather_pipeline.yaml — verdict: Medium

Issues:

  • [Medium] Prompt over-specification: lines 24–30 prescribe exact $vars paths ($vars.geocodeCity.output.body.results[0].latitude, $vars.fetchWeather.output.body.current.temperature_2m) and instruct the agent to normalize the city to "Bellevue" before geocoding. These are procedural hints about HTTP response traversal and data-prep steps that the skill should teach. The agent gets the answer sheet for the .output.body chaining pattern rather than discovering it from the skill.

Suggested fixes:

  • Remove the specific variable-name examples (geocodeCity, fetchWeather) — these are implementation choices the agent should make, not test fixtures.
  • Consider reducing the .output.body hint to a single generic sentence (e.g., "HTTP action responses are nested under .output.body") rather than spelling out full paths for both geocode and weather responses. This preserves the framework-quirk hint without prescribing the exact traversal.
  • Alternatively, if the skill's own reference docs already document .output.body chaining, remove the hint entirely and let the skill teach it.

Within-PR duplicates

  • No duplicate clusters detected (only 1 file changed).

Conclusion

  • ⚠ 1 task has issues, max severity Medium. Advisory only — not blocking merge. Evidence of passing run is missing from the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant