Skip to content

docs(uipath-maestro-flow): add table of contents to two large shared docs#799

Open
uisherif wants to merge 1 commit into
mainfrom
docs/maestro-flow-shared-doc-tocs
Open

docs(uipath-maestro-flow): add table of contents to two large shared docs#799
uisherif wants to merge 1 commit into
mainfrom
docs/maestro-flow-shared-doc-tocs

Conversation

@uisherif
Copy link
Copy Markdown
Collaborator

⚠️ For discussion — do not merge until ready. PR #2 of six from the same uipath-maestro-flow review. Independent of #798.

The problem

Two shared docs in uipath-maestro-flow/references/shared/ are reached by nearly every agent task and read whole because neither has a table of contents:

  • variables-and-expressions.md — 685 lines.
  • file-format.md — 493 lines.

Both have well-structured H2 sections (12 and 13 respectively), but the agent has no way to jump to the one it needs — e.g. "JSON shape of the outputs block", "what --inputs JSON looks like for flow debug", "how subflows scope variables". The skill router in SKILL.md already references these docs for narrow needs, but the agent loads them in full.

In the two hot-path traces from the earlier review:

  • "Greenfield Slack flow" task: variables-and-expressions.md alone added 685 lines to the cumulative read.
  • "Diagnose MST-9107" task: variables-and-expressions.md (685) + file-format.md (493) added 1,178 lines.

Why this fix

A 10–15 line ToC at the top of each file lets an agent (or human) jump straight to the relevant section. Zero content change, no risk to any existing rule or guidance — pure progressive disclosure.

What changes

  • variables-and-expressions.md: insert a ## Table of contents block after the introductory blockquote (line 17), listing the 12 H2 sections with anchor links.
  • file-format.md: insert a ## Table of contents block after the introductory paragraph (line 4), listing the 13 H2 sections with anchor links.

Expected impact

Once the ToC exists, an agent can read the file's intro + ToC (~25 lines) and jump to one or two relevant H2 sections (~50–100 lines each) instead of reading the whole 493- or 685-line file. Estimated savings on a typical task that touches these docs: 300–500 lines of avoided read each time the file is consulted.

No measurable downside — both files still load in full when an agent decides to read top-to-bottom; the ToC just makes targeted access possible.

Validation

  • .maintenance/check-anchors.sh: all 25 new ToC anchor links resolve. The 3 pre-existing bad anchors on main (in editing-operations-json.md and evaluate/CAPABILITY.md) are unchanged.
  • .maintenance/check-links.sh: no new failures.
  • All existing inbound links to either file from other docs continue to resolve — existing H2 anchors are unchanged.

Out of scope

Same out-of-scope list as #798. ToCs on smaller reference files (planning-arch, editing-operations-json, connector/impl, etc.) deferred — they're under or near the 500-line threshold and the value of a ToC on them is lower.

…docs

Add a top-of-file ToC to variables-and-expressions.md (685 lines, 12 H2
sections) and file-format.md (493 lines, 13 H2 sections) so agents and
humans can jump to a specific section instead of reading the whole file.
Pure addition — no existing content modified.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

Claude finished @uisherif's task in 2m 3s —— View job


PR Review: docs(uipath-maestro-flow) — Table of Contents for Shared Docs

  • Gather context (review criteria, CLAUDE.md, skill-review rules)
  • Read full diff
  • Read existing PR conversation
  • Read full files for surrounding context
  • Verify all ToC anchor links resolve to actual headings
  • Check for cross-skill references, secrets, naming conventions
  • Post review

Summary

Adds a ## Table of contents block with anchor links to two large shared reference docs (file-format.md — 509 lines, variables-and-expressions.md — 702 lines). Pure additive change — zero content modifications, zero deletions. Enables agents to jump directly to relevant H2 sections instead of reading entire files.

Change-by-Change Review

1. skills/uipath-maestro-flow/references/shared/file-format.md (+16 lines)

Severity: OK

ToC inserted at line 5, right after the introductory paragraph. Lists all 13 H2 sections with anchor links. Placement is correct — the agent sees the title + one-line intro + ToC before any content.

Anchor format verified against actual headings:

  • Em-dash headings (e.g., ## Edge — both ports required) correctly map to #edge--both-ports-required (GitHub strips , leaving adjacent spaces → double hyphen)
  • Backtick headings (e.g., ## Project structure (from `uip maestro flow init`)) correctly strip backticks and parentheses
  • All 13 anchors match their target H2s

2. skills/uipath-maestro-flow/references/shared/variables-and-expressions.md (+17 lines)

Severity: OK

ToC inserted at line 18, after the introductory blockquote and --- separator. Lists all 12 H2 sections. Placement is sensible — the blockquote contains important "read this before" context that should precede the ToC.

Anchor format verified:

  • Parenthesized backtick headings (e.g., ## Workflow Variables (`globals`)) correctly map to #workflow-variables-globals
  • All 12 anchors match their target H2s

What's Missing

Nothing identified. This is a minimal, well-scoped change. The PR description correctly notes that ToCs for smaller files are deferred.

Area Ratings

Area Status Notes
Frontmatter N/A No frontmatter changes
E2E Tests N/A Documentation-only change, no behavior change
Skill Body N/A SKILL.md not modified
References & Assets OK ToC blocks correctly placed, all anchors verified
Repo Hygiene OK No cross-skill refs, no secrets, scoped to target files only

Issues for Manual Review

None found.

Conclusion

Clean, low-risk, purely additive change. All 25 ToC anchor links resolve correctly against their target H2 headings. The ToC placement in both files is sensible — after introductory context, before the first content section. No issues found. Approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants