Code Review - PR #499: Fix nested f-strings formatting for Python 3.11

Summary

This PR fixes a Python 3.11 compatibility issue by changing nested f-string syntax from double quotes to single quotes in an error message.

Code Quality: ✅ APPROVED

Positive aspects:

• Correct fix: This change addresses a real Python 3.11 syntax limitation. Python 3.11 doesn't allow nested f-strings using the same quote style (e.g., f"...f"..."), which would cause a SyntaxError.
• Minimal and focused: The change is surgical - only touches the problematic line without unnecessary modifications.
• Maintains functionality: The error message output remains identical; only the quote style changes.
• Location: src/upsonic/tools/schema.py:172

Testing: ⚠️ Needs Verification

Recommendations:

1. Verify CI passes: The project tests against Python 3.10, 3.11, and 3.12 (per .github/workflows/tests.yml). This PR should ensure Python 3.11 tests pass.
2. Run existing test: The file tests/unit_tests/tools/test_tool_schema.py contains test test_tool_schema_validation_errors which exercises this code path. Ensure it passes.
3. Manual verification: Consider testing with a function that has missing annotations to trigger this error message:

def test_func(param):  # Missing type annotation
    """Test function."""
    return param

Best Practices: ✅ GOOD

Observations:

• The fix follows Python's recommendation to use different quote styles for nested strings
• Alternative approaches (using "".join(...) or triple quotes) would be more verbose without adding value
• The change is backwards compatible with Python 3.10+

Security: ✅ NO CONCERNS

No security implications - this is a string formatting change in error messaging.

Performance: ✅ NO IMPACT

Negligible performance difference between quote styles.

Additional Observations

Context check:

• The error message is part of the tool function validation system at src/upsonic/tools/schema.py:169-173
• This validation ensures tool functions have proper type annotations
• The message correctly lists missing annotation parameters

Potential issues to consider:

1. No other instances found: I searched the codebase and found no other similar nested f-string patterns that would fail on Python 3.11.
2. Pre-commit hooks: The project uses pre-commit hooks that run pytest. Ensure this passes before merging.

Recommendation: ✅ APPROVE WITH VERIFICATION

This is a valid bug fix that should be merged once CI tests pass. The change is correct, minimal, and addresses a real Python 3.11 compatibility issue.

Action items before merge:

• Verify GitHub Actions CI passes all Python versions (3.10, 3.11, 3.12)
• Ensure pre-commit hooks pass
• No additional changes needed

Great catch on this Python 3.11 compatibility issue! 👍