Diff Before Upload comparing filesize and last modified time.#90
Merged
Conversation
Contributor
Author
|
Travis failed on hhvm due to 'yield'. :\ |
publiux
pushed a commit
to publiux/laravelcdn
that referenced
this pull request
Jan 17, 2016
|
I think this is a great PR. I created a fork of this project that I intend to maintain since this one seems slow to implement simple fixes. It is located at https://github.com/publiux/laravelcdn . I have integrated your pull request into the fork and have provided you with appropriate credit for the code. Thanks! |
Contributor
Author
|
Any news about this one? @Mulkave |
Member
|
Sorry for the delay on this one, will merge and allow failures on HHVM since it's not required as first-class support in this package. |
Mulkave
added a commit
that referenced
this pull request
Feb 21, 2016
Diff Before Upload comparing filesize and last modified time.
Contributor
Author
|
@Mulkave Great! Could you also push these changes to a new version on packagist? :) thanks. |
Member
|
@filipegar all up now, thanks a bunch 😄 |
This was referenced Feb 21, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, I think I've achieved this in a very good way.
To fix bug #26 and #84 I created a routine that gets a list of everything on bucket and conflicts with the collections of $assets received to upload. I check last modified time and file size. If both are different, the file passes this validation and gets uploaded.