Skip to content

Conversation

@artem-dudarev
Copy link
Contributor

@artem-dudarev artem-dudarev commented Oct 31, 2025

Description

References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-4012

Artifact URL:


Note

Normalize cache keys to lowercase and make cache regions/key lookups case-insensitive, with corresponding tests.

  • Caching Core:
    • Introduce CacheKey.Normalize(object|string) to lowercase string keys.
    • Update CacheKey.With(Type, ...) to return normalized keys.
  • PlatformMemoryCache:
    • Normalize keys in CreateEntry, TryGetValue, and Remove using CacheKey.Normalize.
  • MemoryCacheExtensions:
    • Normalize keys in GetOrCreateExclusive and GetOrCreateExclusiveAsync.
  • Cancellable Cache Regions:
    • Use case-insensitive storage and comparisons: _keyTokensDict = new(... OrdinalIgnoreCase), EqualsIgnoreCase, StartsWithIgnoreCase.
  • Tests:
    • Add/extend unit tests verifying case-insensitive behavior for cache keys and token cancellation across PlatformMemoryCache, CancellableCacheRegion, and extension methods.

Written by Cursor Bugbot for commit 9e338bd. This will update automatically on new commits. Configure here.

Image tag:
ghcr.io/VirtoCommerce/platform:3.915.0-pr-2954-e9ab-vcst-4012-cache-key-e9abb77d

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.919
Timestamp: 05-11-2025T14:26:10

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.508
Timestamp: 05-11-2025T19:29:19

@sonarqubecloud
Copy link

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.228
Timestamp: 10-11-2025T13:39:38

@artem-dudarev artem-dudarev merged commit 371cd2e into dev Nov 10, 2025
15 checks passed
@artem-dudarev artem-dudarev deleted the VCST-4012-cache-key branch November 10, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants