[pull] main from iree-org:main #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue encountered while enabling the pad based encoding: #20835 (comment) When no GPU::L1CacheInfo can be retrieved, the `GPUPadLayoutAttr` is resolved to a `EncodingNopLayoutAttr`, however this results in the following error: ``` LLVM ERROR: can't create Attribute 'mlir::iree_compiler::IREE::Codegen::EncodingNopLayoutAttr' because storage uniquer isn't initialized: the dialect was likely not loaded, or the attribute wasn't added with addAttributes<...>() in the Dialect::initialize() method. ``` While this could be resolved by adding `ctx->getOrLoadDialect<IREE::Codegen::IREECodegenDialect>();` and implementing the SerializableEncodingAttrInterface for `EncodingNopLayoutAttr`, it's chosen to replace the nop encoding attribute resolver with the identity `GPUPadLayoutAttr` resolver. Signed-off-by: Jorn Tuyls <jorn.tuyls@gmail.com>
Signed-off-by: hanhanW <hanhan0912@gmail.com>
-- Initially, the vector distribute pipeline would check for a single `DispatchTensorStoreOp` inside a dispatch. This patch extends to adding vector distribution config in the case of multiple store operations. -- Also, the workgroup tile sizes are added to every operation for compatibility with tileUsingForall. (It updates in the case of reduction and forwards in the case of parallel operation.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )