Skip to content

Release Version 2.9#532

Merged
kprinssu merged 15 commits into
masterfrom
2.9
Nov 5, 2024
Merged

Release Version 2.9#532
kprinssu merged 15 commits into
masterfrom
2.9

Conversation

@kprinssu
Copy link
Copy Markdown
Collaborator

@kprinssu kprinssu commented Jun 26, 2023

Notable changes:

This PR contains various improvements. Huge shout to @ChefKissInc for AMD support, @1Revenger1 for continuous improvements, and @lazd for improving touchscreen support for Surface devices.

Thanks @newperson1746 and @1Revenger1 for the improved Github Actions and fixes.

@kprinssu
Copy link
Copy Markdown
Collaborator Author

Notes for the 2.9 release, we will need to update the documentation and README regarding AMD support.

@kprinssu kprinssu changed the title Release Version 2.0 Release Version 2.9 Jun 26, 2023
@lazd
Copy link
Copy Markdown

lazd commented Aug 18, 2023

I think it would be wise to get VoodooI2C/VoodooI2CHID#69 in before releasing 2.9 as it contains some fixes for my previous PR mentioned in the description above. There are open questions about pens, but I think the touchscreen interaction fixes should definitely go in and we can see if pens work via feedback from users.

@kprinssu
Copy link
Copy Markdown
Collaborator Author

Thanks for the callout @lazd. This release will be delayed until later this year.

@VoodooI2C VoodooI2C deleted a comment from denyx01 Aug 25, 2023
@kprinssu
Copy link
Copy Markdown
Collaborator Author

kprinssu commented Aug 25, 2023

@denyx01 This pull request is not for support. Your comment has been removed as it is spam.

@hacker1024
Copy link
Copy Markdown

The aforementioned PR has now been merged.

@SiddharthManthan

This comment has been minimized.

@VisualEhrmanntraut
Copy link
Copy Markdown
Contributor

VisualEhrmanntraut commented Nov 25, 2023

@SiddharthManthan I've got a build in https://chefkissinc.github.io/guide/gathering-files/kexts#input. It's not 100% up-to-date as the guide is currently undergoing a complete rewrite, but it should work for now. (You could also build VoodooI2C manually)

@kprinssu
Copy link
Copy Markdown
Collaborator Author

Please release this version as early as possible. Many AMD laptops are lacking touchpad support.

This is a PR to track changes in the new version. This is not a place to spam asking it for released.

@VoodooI2C VoodooI2C locked and limited conversation to collaborators Nov 25, 2023
@kprinssu kprinssu self-assigned this Nov 26, 2023
@VoodooI2C VoodooI2C unlocked this conversation Dec 22, 2023
* Create objective-c-xcode.yml

* Update objective-c-xcode.yml

* objective-c-xcode.yml: Update setup tools to fix pyparsing

* objective-c-xcode.yml: try fixing pyparsing directly

* objective-c-xcode.yml: use my fixed cldoc

* objective-c-xcode.yml: manually updating pyparsing was always useless
@stevezz3
Copy link
Copy Markdown
Contributor

stevezz3 commented Mar 8, 2024

Hi @kprinssu I am sorry if this bothers you. Build from the latest commit #530 will freeze trackpad on my ELAN.
As I perceive so far, VoodooI2C/VoodooGPIO@e0ca3d2 is in good shape, and I am happy to see it pushed and watch AMD users' feedback.

@kprinssu
Copy link
Copy Markdown
Collaborator Author

kprinssu commented Mar 8, 2024

Hi @kprinssu I am sorry if this bothers you. Build from the latest commit #530 will freeze trackpad on my ELAN. As I perceive so far, VoodooI2C/VoodooGPIO@e0ca3d2 is in good shape, and I am happy to see it pushed and watch AMD users' feedback.

That commit is pretty big and introduces AMD support. I am unsure what could cause breakage with your device.

@JustinJiangNext
Copy link
Copy Markdown

JustinJiangNext commented Apr 1, 2024

Built.zip
Here is a build of I2C and satellites for 2.9. Testing and feedback could be helpful.
(target is set to 14.4)

@LukeMech
Copy link
Copy Markdown

LukeMech commented May 25, 2024

Built.zip Here is a build of I2C and satellites for 2.9. Testing and feedback could be helpful. (target is set to 14.4)

Build doesn't include VoodooI2CHID "recent" pushes I think, or they don't help in Lenovo Yoga 3rd Pen (it works up to 2.6.5 version, I tried compiling myself with latest VoodooI2CHID repo commits but ran into some problems so can't really check that for now)

@averycblack
Copy link
Copy Markdown
Contributor

If you don't mind testing out palm rejection and only have Elan/HID devices, this build here should work.

@LukeMech
Copy link
Copy Markdown

I was sure I've got Synaptics touchpad, but deleting Synaptics kext didn't break it and using just mentioned by you files did a trick - pen works again, thanks!

@LeeBinder
Copy link
Copy Markdown

@LukeMech download, unzip and run DIsplay info about ELAN Trackpad.zip

Content:


#!/bin/bash
clear
ioreg -l | grep ELAN
echo
# source: https://github.com/Qonfused/ASUS-ZenBook-Duo-14-UX481-Hackintosh/issues/12#issuecomment-1332945899
ioreg -rxn IOHIDInterface -k "VoodooI2CServices Supported" -t | grep -E 'IOACPIPlatformDevice|IOPCIDevice|VoodooI2CDeviceNub|VendorID|ProductID|HIDEventDriver  <class VoodooI2C|Interface  <class VoodooI2C' | cut -d "<" -f1

@LukeMech
Copy link
Copy Markdown

LukeMech commented May 25, 2024

Nothing reported :p

@LeeBinder
Copy link
Copy Markdown

run again and scroll up (looks as if your scrolled down too much)

@LukeMech
Copy link
Copy Markdown

run again and scroll up (looks as if your scrolled down too much)

Nah, there is just nothing (I'm sure it's synaptics, it's lenovo x1 yoga 3rd laptop)
Zrzut ekranu 2024-05-25 o 20 58 47

@LeeBinder
Copy link
Copy Markdown

Very most likely. What's above all important is that your yoga's pen works again 👍

* Drop CircleCI

* Switch back to VoodooI2C cldoc fork
@stevezz3
Copy link
Copy Markdown
Contributor

@kprinssu Hi, I see the pip install cldoc command does not go through due to the error Python environment. I suggest adding the following stage before src=... command in the yaml file.

      # Python 3.10 is not compatible with VoodooI2C cldoc
      - uses: actions/setup-python@v5
        with:
            python-version: '3.9'
      - run: src=$(/usr/bin/curl -Lfs https://raw.githubusercontent.com/acidanthera/VoodooInput/master/VoodooInput/Scripts/bootstrap.sh) && eval "$src" && mv VoodooInput Dependencies
      - run: pip3 install -q cpplint || exit 1
      - run: pip3 install -q git+https://github.com/VoodooI2C/cldoc.git || exit 1
      - run: git submodule init && git submodule update
...

which works in my GitHub Action setup.

kprinssu and others added 4 commits June 12, 2024 07:57
* Create main.yml

* Remove Pip Cache

* Fix Lint in VoodooI2CController.cpp

* Fix VoodooI2CControllerDriver Lint

* Try cursorkind=350

* Only allow one job

* Add separate lint and doc tasks, add archive script

* Fix generate description output, missing dependencies

* Use -r in pip install

* build_docs -> build_doc

* Build VoodooInput for docs

* Release try two

* Test commit

* Test commit 2

* Fix num commits and last_ten_commits

* Set number of max commits

* Fetch tags

* Get tags try 2

* Fix git fetch

* Revert back to using the published trigger

* Save off last tagged commit

* I forgot to save the conflict resolution :(

* Fix VoodooI2CHID submodule commit

* Update to latest master for VoodooI2CHID

* Update cldoc to clang 15

* Update cldoc to VoodooI2C master

* Fix NUM_COMMITS

* Echo release notes

* Make sure to output to

* Account for multiline output

* checkout depth 500

* Multi-line input for release action

* Use softprops release action

* Use file to store changelog

* Upload docs to github pages

* Fix repository name match

* Fix upload always running (oops)
* Add confidence bit for palm rejection

* Set Confidence bit by default

* Remove logging

* Use constant for palm type
Comment thread .github/workflows/objective-c-xcode.yml Outdated
Copy link
Copy Markdown
Contributor

@averycblack averycblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out the build artifacts on my Chromebook - LGTM

@kprinssu kprinssu merged commit 4f3206b into master Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.