Conversation
|
Notes for the 2.9 release, we will need to update the documentation and README regarding AMD support. |
|
I think it would be wise to get VoodooI2C/VoodooI2CHID#69 in before releasing 2.9 as it contains some fixes for my previous PR mentioned in the description above. There are open questions about pens, but I think the touchscreen interaction fixes should definitely go in and we can see if pens work via feedback from users. |
|
Thanks for the callout @lazd. This release will be delayed until later this year. |
|
@denyx01 This pull request is not for support. Your comment has been removed as it is spam. |
|
The aforementioned PR has now been merged. |
This comment has been minimized.
This comment has been minimized.
|
@SiddharthManthan I've got a build in https://chefkissinc.github.io/guide/gathering-files/kexts#input. It's not 100% up-to-date as the guide is currently undergoing a complete rewrite, but it should work for now. (You could also build VoodooI2C manually) |
This is a PR to track changes in the new version. This is not a place to spam asking it for released. |
* Create objective-c-xcode.yml * Update objective-c-xcode.yml * objective-c-xcode.yml: Update setup tools to fix pyparsing * objective-c-xcode.yml: try fixing pyparsing directly * objective-c-xcode.yml: use my fixed cldoc * objective-c-xcode.yml: manually updating pyparsing was always useless
|
Hi @kprinssu I am sorry if this bothers you. Build from the latest commit #530 will freeze trackpad on my ELAN. |
That commit is pretty big and introduces AMD support. I am unsure what could cause breakage with your device. |
|
Built.zip |
Build doesn't include VoodooI2CHID "recent" pushes I think, or they don't help in Lenovo Yoga 3rd Pen (it works up to 2.6.5 version, I tried compiling myself with latest VoodooI2CHID repo commits but ran into some problems so can't really check that for now) |
|
If you don't mind testing out palm rejection and only have Elan/HID devices, this build here should work. |
|
I was sure I've got Synaptics touchpad, but deleting Synaptics kext didn't break it and using just mentioned by you files did a trick - pen works again, thanks! |
|
@LukeMech download, unzip and run DIsplay info about ELAN Trackpad.zip Content: |
|
Nothing reported :p |
|
run again and scroll up (looks as if your scrolled down too much) |
|
Very most likely. What's above all important is that your yoga's pen works again 👍 |
* Drop CircleCI * Switch back to VoodooI2C cldoc fork
|
@kprinssu Hi, I see the pip install cldoc command does not go through due to the error Python environment. I suggest adding the following stage before which works in my GitHub Action setup. |
* Create main.yml * Remove Pip Cache * Fix Lint in VoodooI2CController.cpp * Fix VoodooI2CControllerDriver Lint * Try cursorkind=350 * Only allow one job * Add separate lint and doc tasks, add archive script * Fix generate description output, missing dependencies * Use -r in pip install * build_docs -> build_doc * Build VoodooInput for docs * Release try two * Test commit * Test commit 2 * Fix num commits and last_ten_commits * Set number of max commits * Fetch tags * Get tags try 2 * Fix git fetch * Revert back to using the published trigger * Save off last tagged commit * I forgot to save the conflict resolution :( * Fix VoodooI2CHID submodule commit * Update to latest master for VoodooI2CHID * Update cldoc to clang 15 * Update cldoc to VoodooI2C master * Fix NUM_COMMITS * Echo release notes * Make sure to output to * Account for multiline output * checkout depth 500 * Multi-line input for release action * Use softprops release action * Use file to store changelog * Upload docs to github pages * Fix repository name match * Fix upload always running (oops)
* Add confidence bit for palm rejection * Set Confidence bit by default * Remove logging * Use constant for palm type
averycblack
left a comment
There was a problem hiding this comment.
Tested out the build artifacts on my Chromebook - LGTM
Notable changes:
This PR contains various improvements. Huge shout to @ChefKissInc for AMD support, @1Revenger1 for continuous improvements, and @lazd for improving touchscreen support for Surface devices.
Thanks @newperson1746 and @1Revenger1 for the improved Github Actions and fixes.