Fix unexpired destinations limit return to handle new algorithm #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csharrison
approved these changes
Dec 13, 2022
|
I would avoid using the term "implementation" to refer to a spec algorithm. Can you reword the subject / description to use something like "algorithm" instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The algorithm changes for checking unexpired destination limit from #601 includes appending the new source's destinations with the set holding the currently stored destinations when checking if the size has surpassed the max destinations per source site. Previously, the new source's destination was never appended to this set, so it made sense to have the set's size check be greater than or equal to the max limit, but now it makes more sense to make the condition just greater than.
Preview | Diff