Add some words about async iteration #194
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domfarolino
reviewed
Jan 30, 2025
| controller.abort(); | ||
| }); | ||
| }, | ||
| { signal: controller.signal }, |
Collaborator
There was a problem hiding this comment.
Let's revert changes like this which are just stylistic and probably automated by an editor.
Collaborator
Author
There was a problem hiding this comment.
They're from our committed prettier config.
I recommend leaving it like this. Most JavaScript and Typescript developers use Prettier and are comfortable with the decisions it makes
Collaborator
There was a problem hiding this comment.
Can you revert them or only format the changes relevant to this PR instead of the whole file? That'd make it easier to review and better scoped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to address questions about why we don't want to use
AsyncIteratorto handle events.cc @domfarolino