AudioWorkletNodeOptions.processorOptions should not default to null. #2011

Activity

1. hoch

   self-assigned this

   on Jul 25, 2019
2. guest271314 commented on Jul 25, 2019

   

   guest271314

   on Jul 25, 2019 · Hidden as off-topic

   show commentMore actions
3. hoch commented on Jul 25, 2019

   

   hoch

   on Jul 25, 2019

   MemberAuthor

   More actions

   The setup code:

   const node = new AudioWorkletNode(context, 'processor', nodeOptions);

   class extends AudioWorkletProcessor {
     constructor(options){
       console.log(options);
     }
   }

   When nodeOptions = {}:

   {numberOfInputs: 1, numberOfOutputs:1}

   When nodeOptions = {foo: 'bar'}:

   {numberOfInputs: 1, numberOfOutputs:1}

   When nodeOptions = {foo:bar, processorOptions: {foo:'bar'}}:

   {numberOfInputs: 1, numberOfOutputs:1, processorOptions: {foo:'bar'}}
4. hoch commented on Jul 25, 2019

   

   hoch

   on Jul 25, 2019

   MemberAuthor

   More actions

   From WG Telecon:
   Remove the nullable type and the default value from processorOptions.
5. karlt commented on Jul 25, 2019

   

   karlt

   on Jul 25, 2019

   Last edited by karlt

   Contributor

   More actions

   I'm not aware of any benefit in processorOptions being nullable.

   If the value could default to the empty object, then that would permit clients to test for members without throwing a TypeError when processorOptions is not specified, but I don't think it is possible to specify an empty object default in WebIDL.

   So, yes, the proposed change seems the best option available.

   👍React with 👍1Reacted by Hongchan Choi
6. hoch

   closed this as completedin #2013on Jul 29, 2019