Fix nn to process multiple stdin lines #10
Merged
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, nn only processed the first line from stdin using lines.next(). Now it loops through all lines, processing each non-empty line separately. This allows users to pipe multiple lines of input and have each line formatted independently.
Modified stdin processing to print blank lines as-is rather than skipping them. This maintains the original formatting of the input while still processing all non-empty lines.
Replace nested if-let with map_while(Result::ok) as suggested by clippy. This avoids potential infinite loops on repeated I/O errors and is more idiomatic Rust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.