[Demonology] Initial Demonology support. #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some might be missing, most likely pet spells
Won't probably change anything since they're not tracked anyway due to their nature
Felstorm still broken
Might be a little redundant since we now have playerPets in the Parser, but since it extends Entity, we could be able to track buffs on the pets etc. Also convenient to get the pet from event by getEntity(event).
MartijnHols
reviewed
Sep 17, 2017
| const percentage = actualCasts / maxCasts; | ||
| when(percentage).isLessThan(1) | ||
| .addSuggestion((suggest, actual, recommended) => { | ||
| return suggest(<span>You should cast <SpellLink id={SPELLS.SUMMON_DOOMGUARD_UNTALENTED.id}/> or <SpellLink id={SPELLS.SUMMON_INFERNAL_UNTALENTED.id}/> more often. Doomguard is best for single target while Infernal is better for AoE. Try to pair up the cooldowns with Bloodlust like buffs (Bloodlust, Heroism, Time Warp etc.).</span>) |
Member
There was a problem hiding this comment.
Could make Bloodlust a SpellLink too.
| return suggest(<span>You should cast <SpellLink id={SPELLS.SUMMON_DOOMGUARD_UNTALENTED.id}/> or <SpellLink id={SPELLS.SUMMON_INFERNAL_UNTALENTED.id}/> more often. Doomguard is best for single target while Infernal is better for AoE. Try to pair up the cooldowns with Bloodlust like buffs (Bloodlust, Heroism, Time Warp etc.).</span>) | ||
| .icon(SPELLS.SUMMON_DOOMGUARD_UNTALENTED.icon) | ||
| .actual(`${actualCasts} out of ${maxCasts} summons.`) | ||
| .recommended(`${maxCasts} is recommended`) |
| const doomUptime = this.enemies.getBuffUptime(SPELLS.DOOM.id) / this.owner.fightDuration; | ||
| when(doomUptime).isLessThan(0.95) | ||
| .addSuggestion((suggest, actual, recommended) => { | ||
| return suggest('Your Doom uptime can be improved. Try to pay more attention to your Doom on the boss, as it is one of your Soul Shard generators.') |
Member
There was a problem hiding this comment.
Can use some SpellLinks for first mentions of spells.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry it's huge, it's just the initial PR, I'll try to keep the following PRs smaller again.
Added initial support for Demonology Warlocks:
Also added a Pet/Pets modules for Core Parser (extends Entity/Entities), could be useful in the future (courtesy of @shighman).
Last but not least - refactored the specs to use new
playerPetsinstead of manually filteringreport.friendlyPetsand some minor fixes I missed earlier.EDIT: Also reworked the CooldownTracker, see PR #318.