Added basic support for Protection Warrior. #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created the basic module for Protection Warriors in CastEfficiency, AlwaysBeCasting, and Spells. Created DamageDone, DamageTaken, and HealingDone Cores.
This reverts commit feeb2f8.
Created the basic module for Protection Warriors in CastEfficiency, AlwaysBeCasting, and Spells. Created DamageDone, DamageTaken, and HealingDone Cores.
This reverts commit feeb2f8.
Added basic modules for Protection Warrior. Added
MartijnHols
approved these changes
Sep 22, 2017
Member
MartijnHols
left a comment
There was a problem hiding this comment.
Thanks for the PR, good first PR! I left a few comments that you could consider for a future PR. Merging this in a second (I'll be making a small change, so you'll need to pull and merge).
|
|
||
| import StatisticBox, { STATISTIC_ORDER } from 'Main/StatisticBox'; | ||
|
|
||
| class HealingDone extends CoreHealingDone { |
Member
There was a problem hiding this comment.
Recent changes made it so this can be replaced with 2 lines in your CombatLogParser to get a version including a healing vs overhealing bar; https://github.com/MartijnHols/WoWAnalyzer/blob/f90370b34593f84fa0d3d90a92a551c9c6e7660d/src/Parser/HolyPaladin/CombatLogParser.js#L67
| getCooldown: haste => 15 | ||
| charges: 2, | ||
| }, | ||
| { |
Member
There was a problem hiding this comment.
Things like this should probably get
noSuggestion: true,
noCanBeImproved: true,| @@ -0,0 +1,7 @@ | |||
| import CoreDamageTaken from 'Parser/Core/Modules/DamageTaken'; | |||
|
|
|||
| class DamageTaken extends CoreDamageTaken { | |||
Contributor
Author
|
Thank you! I'll work on those and get them all fixed for sure. New to all this, very excited to get the rest of it up and running! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the first steps to creating the module for the spec. Has components for damage done & taken, healing done, and added abilities into the class spell folder.