More updates to Elemental and Enhancement for Midnight #7560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates Elemental and Enhancement Shaman specs for the Midnight expansion, including restoration of accidentally deleted abilities, removal of obsolete talents, and addition of new Maelstrom resource tracking.
Key Changes:
- Restored Master of the Elements for Elemental after accidental deletion
- Removed Stormkeeper window analysis and Primal Elementalist (no longer controllable)
- Added Elemental Tempo CDR tracking for Enhancement
- Updated Maelstrom Weapon resource tracking with new/changed spells
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/common/SPELLS/shaman.ts | Added Chain Lightning Ride the Lightning damage spell, Master of the Elements buff, and Flametongue Imbuement Mastery Tornado; removed Awakening Storms spells |
| src/analysis/retail/shaman/shared/Abilities.tsx | Updated Flame Shock cooldown and added Voltaic Blaze ability configuration |
| src/analysis/retail/shaman/enhancement/modules/talents/ThorimsInvocation.tsx | Updated for Doom Winds/Ascendance integration with Stormstrike/Crash Lightning triggers |
| src/analysis/retail/shaman/enhancement/modules/talents/Stormblast.tsx | Removed entire file (talent removed from game) |
| src/analysis/retail/shaman/enhancement/modules/talents/HotHand.tsx | Added Totemic Momentum extension tracking and updated Splitstream references |
| src/analysis/retail/shaman/enhancement/modules/talents/ElementalTempo.tsx | New analyzer for Elemental Tempo CDR with waste tracking |
| src/analysis/retail/shaman/enhancement/modules/talents/ElementalAssault.tsx | Updated Stormstrike spell ID references |
| src/analysis/retail/shaman/enhancement/modules/talents/DoomWinds.tsx | Complete rewrite merging Ascendance functionality |
| src/analysis/retail/shaman/enhancement/modules/talents/Ascendance.tsx | Now exports DoomWinds module |
| src/analysis/retail/shaman/enhancement/modules/spells/Stormsurge.tsx | Updated Stormstrike spell ID references |
| src/analysis/retail/shaman/enhancement/modules/normalizers/* | Updated Maelstrom resource tracking logic for new spells and Static Accumulation |
| src/analysis/retail/shaman/enhancement/modules/core/SpellUsable.tsx | Updated Stormstrike spell ID |
| src/analysis/retail/shaman/enhancement/modules/Abilities.tsx | Removed Feral Spirit, updated Stormstrike ID, adjusted Lava Lash cooldown |
| src/analysis/retail/shaman/enhancement/constants.ts | Updated Stormstrike references and Maelstrom-eligible spells |
| src/analysis/retail/shaman/enhancement/CombatLogParser.tsx | Replaced Ascendance with DoomWinds, added ElementalTempo, removed StormBlast |
| src/analysis/retail/shaman/enhancement/CHANGELOG.tsx | Added changelog entry for Elemental Tempo |
| src/analysis/retail/shaman/elemental/modules/talents/Stormkeeper.tsx | Removed major cooldown analysis (only damage tracking remains) |
| src/analysis/retail/shaman/elemental/modules/talents/PrimalElementalist.tsx | Removed entire file (Storm Elemental no longer controllable) |
| src/analysis/retail/shaman/elemental/modules/talents/MasterOfTheElements.tsx | New analyzer tracking buffed ability usage |
| src/analysis/retail/shaman/elemental/modules/talents/Ascendance.tsx | Added SpellLink to guide subsection title |
| src/analysis/retail/shaman/elemental/modules/hero/farseer/CallOfTheAncestors.tsx | Added Stormkeeper to ancestor summon spells and updated title |
| src/analysis/retail/shaman/elemental/modules/features/MaelstromSpenders.tsx | Added Master of the Elements integration to spender analysis |
| src/analysis/retail/shaman/elemental/modules/core/FlameShock.tsx | New elemental-specific FlameShock with guide subsection |
| src/analysis/retail/shaman/elemental/modules/Buffs.tsx | Added Master of the Elements buff tracking |
| src/analysis/retail/shaman/elemental/guide/* | Restructured guide layout and removed FlameShockSubSection |
| src/analysis/retail/shaman/elemental/CombatLogParser.tsx | Replaced PrimalElementalist with MasterOfTheElements, updated FlameShock import |
| src/analysis/retail/shaman/elemental/CHANGELOG.tsx | Fixed formatting |
Comments suppressed due to low confidence (2)
src/analysis/retail/shaman/enhancement/modules/talents/ElementalTempo.tsx:1
- Division by zero is possible if scaledCooldown is 0. Add a check to ensure scaledCooldown is non-zero before dividing.
src/analysis/retail/shaman/enhancement/modules/talents/HotHand.tsx:1 - The variable slipstreamMissedSunderings references Slipstream, but the code checks this.reactivity which suggests the old 'reactivity' naming. Consider renaming the property this.reactivity to this.slipstream or this.splitstream for consistency with the new talent name.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/analysis/retail/shaman/enhancement/modules/talents/DoomWinds.tsx
Outdated
Show resolved
Hide resolved
src/analysis/retail/shaman/enhancement/modules/talents/DoomWinds.tsx
Outdated
Show resolved
Hide resolved
bd6b9ce to
788f780
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 51 out of 51 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/analysis/retail/shaman/enhancement/modules/talents/HotHand.tsx
Outdated
Show resolved
Hide resolved
src/analysis/retail/shaman/enhancement/modules/talents/DoomWinds.tsx
Outdated
Show resolved
Hide resolved
src/analysis/retail/shaman/enhancement/modules/talents/HotHand.tsx
Outdated
Show resolved
Hide resolved
src/analysis/retail/shaman/enhancement/modules/talents/DoomWinds.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 52 out of 52 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,7 +1,9 @@ | |||
| import { change, date } from 'common/changelog'; | |||
| import { TALENTS_SHAMAN } from 'common/TALENTS'; | |||
There was a problem hiding this comment.
Unused import TALENTS_SHAMAN.
Suggested change
| import { TALENTS_SHAMAN } from 'common/TALENTS'; |
| import { change, date } from 'common/changelog'; | ||
| import { TALENTS_SHAMAN } from 'common/TALENTS'; | ||
| import { Seriousnes } from 'CONTRIBUTORS'; | ||
| import SpellLink from 'interface/SpellLink'; |
There was a problem hiding this comment.
Unused import SpellLink.
Suggested change
| import SpellLink from 'interface/SpellLink'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Elemental
Enhancement
Testing
/report/...