update midnight to React 19 #7523
Merged
+3,781
−3,587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Collaborator
|
i see this is a draft. is it good to put on |
Contributor
Author
|
should be good to do so - there were a lot of lint issues that I'm going to fix, I just wanted to get the bones up off my PC for looking at |
Collaborator
|
note before i forget: i believe |
e29fc0b to
9fdcf42
Compare
# Conflicts: # scripts/lint-baseline/baseline.ts # src/analysis/retail/mage/fire/guide/SunKingsBlessing.tsx # src/analysis/retail/mage/frost/core/IcyVeins.tsx # src/analysis/retail/mage/frost/talents/Cryopathy.tsx # src/analysis/retail/mage/frost/talents/FrozenOrb.tsx # src/analysis/retail/mage/frost/talents/GlacialSpike.tsx # src/analysis/retail/mage/frost/talents/ShiftingPowerFrost.tsx # src/analysis/retail/monk/mistweaver/modules/spells/ChiBurst.tsx # src/interface/guide/index.tsx
these are primarily noise from the midnight changes to the header, along with changes to an error with dom nesting that we were ignoring before. i've fixed the remaining 2 issues with `validateDOMNesting`, and removed the ignore for the moment, I also enabled `handleExpansionChecker` so that previous-expansion logs in configs pass e2e. this will get turned back off closer to midnight release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
/report/...