-
Notifications
You must be signed in to change notification settings - Fork 650
Implement Aug tier set #7527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Aug tier set #7527
Conversation
Also modifies Threads of Fate module, as currently it still triggers, presumably due to the talent ID being reused for Nozdormu Adept...
Implement personal EM damage amp for Duplicate. Adjust Eruption amp for Duplicate to account for it also being increased by the personal EM amp. Adjust Motes colours to make the graph easier to read.
emallson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like @Krealle reviewed the previous version so i'll defer to them on this one (and because i don't know anything about aug). the code changes look mostly okay
src/analysis/retail/evoker/shared/modules/talents/hero/chronowarden/ThreadsOfFate.tsx
Outdated
Show resolved
Hide resolved
src/analysis/retail/evoker/augmentation/modules/talents/Duplicate.tsx
Outdated
Show resolved
Hide resolved
src/analysis/retail/evoker/augmentation/modules/talents/Duplicate.tsx
Outdated
Show resolved
Hide resolved
This reverts commit f8c3381.
Change the colours again (as in the reverted commit)
Krealle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, will push in some changes to fix the flameshaper CI complaints and then merge so it can build properly 👍
This reverts commit 09d0638.
Implements the new tier set and removes the old one.
Previous pull request was #7490 but had to re-fork.